From: Mark Rutland <mark.rutland@arm.com>
To: Kumar Gala <galak@codeaurora.org>
Cc: "balbi@ti.com" <balbi@ti.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Pawel Moll <Pawel.Moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding
Date: Fri, 9 Aug 2013 17:28:49 +0100 [thread overview]
Message-ID: <20130809162848.GW27325@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1376062832-23288-1-git-send-email-galak@codeaurora.org>
On Fri, Aug 09, 2013 at 04:40:32PM +0100, Kumar Gala wrote:
> The binding spec wasn't clear that the order of the phandles in the
> usb-phy array has meaning. Clarify this point in the binding that
> it should be <USB2-HS-PHY, USB3-SS-PHY>.
>
> Signed-off-by: Kumar Gala <galak@codeaurora.org>
> ---
> Documentation/devicetree/bindings/usb/dwc3.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 7a95c65..8a9770b 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -6,7 +6,9 @@ Required properties:
> - compatible: must be "synopsys,dwc3"
> - reg : Address and length of the register set for the device
> - interrupts: Interrupts used by the dwc3 controller.
> - - usb-phy : array of phandle for the PHY device
> + - usb-phy : array of phandle for the PHY device. The first element
> + in the array is expected to be a handle to the USB2/HS PHY and
> + the second element is expected to be a handle to the USB3/SS PHY
Just to check - it's not valid to have a USB3 phy without a USB2 phy?
Mark.
next prev parent reply other threads:[~2013-08-09 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 15:40 [PATCH] usb: dwc3: core: clarify usb-phy array binding Kumar Gala
2013-08-09 16:28 ` Mark Rutland [this message]
2013-08-09 18:42 ` Kumar Gala
2013-08-12 18:05 ` Felipe Balbi
2013-08-13 13:34 ` Mark Rutland
2013-08-27 18:53 ` Felipe Balbi
2013-08-28 16:01 ` Mark Rutland
[not found] ` <20130828160151.GA17229-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-09-18 14:21 ` Felipe Balbi
2013-09-18 16:46 ` Mark Rutland
[not found] ` <20130918164610.GC17453-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-09-18 16:56 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809162848.GW27325@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).