From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.11.231]:43939 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933083Ab3HNUuA (ORCPT ); Wed, 14 Aug 2013 16:50:00 -0400 Date: Wed, 14 Aug 2013 13:49:58 -0700 From: Stephen Boyd Subject: Re: [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block Message-ID: <20130814204958.GA27999@codeaurora.org> References: <1376507361-26907-1-git-send-email-galak@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376507361-26907-1-git-send-email-galak@codeaurora.org> Sender: devicetree-owner@vger.kernel.org To: Kumar Gala Cc: ohad@wizery.com, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Grant Likely , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jeffrey Hugo , Eric Holmberg List-ID: On 08/14, Kumar Gala wrote: > Add driver for Qualcomm MSM Hardware Mutex block that exists on newer MSM > SoC (MSM8974, etc). > > CC: Jeffrey Hugo > CC: Eric Holmberg > Signed-off-by: Kumar Gala Looks good. Reviewed-by: Stephen Boyd > --- > v3: > * moved dt binding into hwlock/ > * removed smp_mb() as they were not needed > * cleanup warning > > v2: > * Fixed init of stride > * Dealt with a number of comments from Stephen Boyd: > - use of instead of > - declaring msm_hwspinlock_of_match once & as const > - drop unneccessary () in an if statement > - style cleanup to have devm_kzalloc on one line > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation