From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ch1ehsobe003.messaging.microsoft.com ([216.32.181.183]:56206 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993Ab3HSGo7 (ORCPT ); Mon, 19 Aug 2013 02:44:59 -0400 Date: Mon, 19 Aug 2013 14:44:41 +0800 From: Nicolin Chen Subject: Re: [PATCH v6 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Message-ID: <20130819064440.GA10950@MrMyself> References: <6A3DF150A5B70D4F9B66A25E3F7C888D07114BC3@039-SN2MPN1-013.039d.mgd.msft.net> <20130819030743.GA10544@MrMyself> <6A3DF150A5B70D4F9B66A25E3F7C888D07116BA7@039-SN2MPN1-013.039d.mgd.msft.net> <20130819062438.GB10544@MrMyself> <6A3DF150A5B70D4F9B66A25E3F7C888D07116CDE@039-SN2MPN1-013.039d.mgd.msft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D07116CDE@039-SN2MPN1-013.039d.mgd.msft.net> Sender: devicetree-owner@vger.kernel.org To: Bhushan Bharat-R65777 Cc: "broonie@kernel.org" , "lars@metafoo.de" , "p.zabel@pengutronix.de" , "s.hauer@pengutronix.de" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , "swarren@wwwdotorg.org" , "festevam@gmail.com" , "timur@tabi.org" , "rob.herring@calxeda.com" , "tomasz.figa@gmail.com" , "shawn.guo@linaro.org" , "linuxppc-dev@lists.ozlabs.org" List-ID: On Mon, Aug 19, 2013 at 02:31:47PM +0800, Bhushan Bharat-R65777 wrote: > > > > We here suppose the reset bit would be cleared -- "The software > > > > reset will last > > > > 8 cycles." from RM, so if this happened to be a failure, the whole > > > > IP module won't be normally working as well. > > > > > > Also add a comment describing this against why cycle = 1000 is selected. > > > > If it is done in 8 cycles, 1000-cycle will be surely a safe value for it. > > As long as it finished in 8 cycles, it would quit anyway. Why against? > > I am not against, I am saying why it was not 200 or 50 or 20 etc. I am saying that write a comment saying this much is sufficient as per specification and so keep 1000/etc as preservative. I did't mean that. The 'against' is from "Also add a comment describing this 'against' why cycle = 1000 is selected." Well, if you insist this extra comment for easy-understand, I'll add them Thank you. Nicolin Chen