From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:45298 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751382Ab3HUJO0 (ORCPT ); Wed, 21 Aug 2013 05:14:26 -0400 Date: Wed, 21 Aug 2013 12:14:07 +0300 From: Dan Carpenter Subject: Re: [patch] mmc: sdhci-bcm-kona: '|' vs '&' typo Message-ID: <20130821091407.GX4713@mwanda> References: <20130821082423.GA5240@elgon.mountain> <52148115.3050703@bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52148115.3050703@bfs.de> Sender: devicetree-owner@vger.kernel.org To: walter harms Cc: Chris Ball , Grant Likely , Rob Herring , Christian Daudt , Arnd Bergmann , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: On Wed, Aug 21, 2013 at 10:57:57AM +0200, walter harms wrote: > > > Am 21.08.2013 10:24, schrieb Dan Carpenter: > > The intent was to test if a flag was set. In the current code the > > conditions are always true. > > I guess that it worked before ... > That leaves the Question: are the tests needed at all ? It's flagging everything as broken, and I presume that isn't good. But on the other hand, these changes do occasionally break things because now a lot of new untested code is used. It really is a good idea for someone to test this. > > Signed-off-by: Dan Carpenter > > --- > > Static checker stuff. Untested. regards, dan carpenter