devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Thumshirn <johannes.thumshirn@men.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Johannes Thumshirn <johannes.thumshirn@men.de>,
	Rob Landley <rob@landley.net>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Wim Van Sebroeck <wim@iguana.be>,
	Guenter Roeck <linux@roeck-us.net>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] documentation/devicetree: Move DT bindigns from gpio to watchdog
Date: Thu, 22 Aug 2013 09:37:42 +0200	[thread overview]
Message-ID: <20130822073740.GA3717@jtlinux> (raw)
In-Reply-To: <5214FA08.7090502@wwwdotorg.org>

On Wed, Aug 21, 2013 at 11:34:00AM -0600, Stephen Warren wrote:
> On 08/21/2013 06:42 AM, Johannes Thumshirn wrote:
> > I accidently put the devicetree bindings for the MEN A21 watchdog driver in
> > Documentation/devicetree/bindings/gpio instead of
> > Documentation/devicetree/bindings/watchdog, this patch addresses this error.
>
> The rename sounds fine, so that part,
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> However, the binding itself doesn't look right; it appears to have a
> single "gpios" property rather than using separate named xxx-gpios
> properties for different things...

Ok, so I'll need something like the following?

watchdog {
	compatible ="men,a021-wdt";
	enable-gpios = <&gpio3 9 1>; /* WD_EN */
	fast-gpios = <&gpio3 10 1>;  /* WD_FAST */
	trig-gpios = <&gpio3 11 1>;  /* WD_TRIG */
	rst0-gpio = <&gpio3 6 1>;    /* RST_CAUSE[0] */
	rst1-gpio = <&gpio3 7 1>;    /* RST_CAUSE[1] */
	rst2-gpio = <&gpio3 8 1>;    /* RST_CAUSE[2] */
};

Or is there something like of_get_named_gpios(...) so I can put all 3 rst-gpios
into one property? A quick grep only revealed of_get_named_gpio(...).

Thanks,
Johannes

  reply	other threads:[~2013-08-22  7:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 12:42 [PATCH] documentation/devicetree: Move DT bindigns from gpio to watchdog Johannes Thumshirn
2013-08-21 17:34 ` Stephen Warren
2013-08-22  7:37   ` Johannes Thumshirn [this message]
2013-08-22 20:20     ` Stephen Warren
2013-08-27 11:10       ` [RFC][PATCH v2] " Johannes Thumshirn
2013-08-27 21:41         ` Stephen Warren
2013-08-28  6:22           ` Johannes Thumshirn
2013-08-28 14:38             ` Stephen Warren
2013-08-28 15:01               ` Johannes Thumshirn
2013-10-01 16:18         ` [RFC, " Guenter Roeck
     [not found] ` <1377088929-23694-1-git-send-email-johannes.thumshirn-csrFAY9JiS4@public.gmane.org>
2013-10-29  7:41   ` [PATCH] " Wim Van Sebroeck
2013-10-29  9:42     ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130822073740.GA3717@jtlinux \
    --to=johannes.thumshirn@men.de \
    --cc=devicetree@vger.kernel.org \
    --cc=ian.campbell@citrix.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=swarren@wwwdotorg.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).