From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:65502 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428Ab3HWOOj (ORCPT ); Fri, 23 Aug 2013 10:14:39 -0400 Date: Fri, 23 Aug 2013 15:14:33 +0100 From: Mark Rutland Subject: Re: [PATCH v3 2/2] max77693: added device tree support Message-ID: <20130823141433.GI25856@e106331-lin.cambridge.arm.com> References: <1377104014-21910-1-git-send-email-a.hajda@samsung.com> <1377104014-21910-3-git-send-email-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1377104014-21910-3-git-send-email-a.hajda@samsung.com> Sender: devicetree-owner@vger.kernel.org To: Andrzej Hajda Cc: "lee.jones@linaro.org" , "rob.herring@calxeda.com" , Pawel Moll , Stephen Warren , Ian Campbell , Rob Landley , Samuel Ortiz , "grant.likely@linaro.org" , Sylwester Nawrocki , Jonghwa Lee , Kyungmin Park , "open list:OPEN FIRMWARE AND..." , open list List-ID: On Wed, Aug 21, 2013 at 05:53:34PM +0100, Andrzej Hajda wrote: > This patch adds only of_match_table. > There are no device specific properties. Could you clarify what functionality this enables and what it doesn't, please? This doesn't seem to enable support for the regulators described in the binding [1] (which from the looks of it needs proof-reading and possibly rework). Are there any changes we might need in future to either support new functionality or to generalise the binding. e.g. do we need a regulator for the LED? Given the binding has never been supported, are we happy now that it best represents the hardware, or are there avenues of improvement *before* it becomes ABI? Thanks, Mark. [1] Documentation/devicetree/bindings/mfd/max77693.txt > > Signed-off-by: Andrzej Hajda > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- > drivers/mfd/max77693.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index 27f5da3..e0b11a9 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -225,11 +225,19 @@ static const struct dev_pm_ops max77693_pm = { > .resume = max77693_resume, > }; > > +#ifdef CONFIG_OF > +static struct of_device_id max77693_dt_match[] = { > + {.compatible = "maxim,max77693"}, > + {}, > +}; > +#endif > + > static struct i2c_driver max77693_i2c_driver = { > .driver = { > .name = "max77693", > .owner = THIS_MODULE, > .pm = &max77693_pm, > + .of_match_table = of_match_ptr(max77693_dt_match), > }, > .probe = max77693_i2c_probe, > .remove = max77693_i2c_remove, > -- > 1.8.1.2 > >