* [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe()
@ 2013-08-23 2:50 Wei Yongjun
2013-08-23 3:53 ` Josh Wu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei Yongjun @ 2013-08-23 2:50 UTC (permalink / raw)
To: dwmw2, grant.likely, rob.herring, artem.bityutskiy, josh.wu,
plagnioj, jg1.han
Cc: yongjun_wei, linux-mtd, devicetree
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/mtd/nand/atmel_nand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 65b302c..093bcf8 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -2047,6 +2047,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(host->dev, "Cannot get HSMC irq!\n");
+ res = irq;
goto err_nand_ioremap;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe()
2013-08-23 2:50 [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe() Wei Yongjun
@ 2013-08-23 3:53 ` Josh Wu
2013-08-23 3:54 ` Josh Wu
2013-08-24 4:44 ` Brian Norris
2 siblings, 0 replies; 4+ messages in thread
From: Josh Wu @ 2013-08-23 3:53 UTC (permalink / raw)
To: Wei Yongjun
Cc: dwmw2, grant.likely, rob.herring, artem.bityutskiy, plagnioj,
jg1.han, yongjun_wei, linux-mtd, devicetree
On 8/23/2013 10:50 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thank you for catch this. And
Acked-by: Josh Wu <josh.wu@atmel.com>
> ---
> drivers/mtd/nand/atmel_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 65b302c..093bcf8 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -2047,6 +2047,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> dev_err(host->dev, "Cannot get HSMC irq!\n");
> + res = irq;
> goto err_nand_ioremap;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe()
2013-08-23 2:50 [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe() Wei Yongjun
2013-08-23 3:53 ` Josh Wu
@ 2013-08-23 3:54 ` Josh Wu
2013-08-24 4:44 ` Brian Norris
2 siblings, 0 replies; 4+ messages in thread
From: Josh Wu @ 2013-08-23 3:54 UTC (permalink / raw)
To: Wei Yongjun
Cc: dwmw2, grant.likely, rob.herring, artem.bityutskiy, plagnioj,
jg1.han, yongjun_wei, linux-mtd, devicetree
Hi, Wei Yongjun
On 8/23/2013 10:50 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Thank you for catch this and
Acked-by: Josh Wu <josh.wu@atmel.com>
> ---
> drivers/mtd/nand/atmel_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 65b302c..093bcf8 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -2047,6 +2047,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> dev_err(host->dev, "Cannot get HSMC irq!\n");
> + res = irq;
> goto err_nand_ioremap;
> }
>
>
Best Regards,
Josh Wu
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe()
2013-08-23 2:50 [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe() Wei Yongjun
2013-08-23 3:53 ` Josh Wu
2013-08-23 3:54 ` Josh Wu
@ 2013-08-24 4:44 ` Brian Norris
2 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2013-08-24 4:44 UTC (permalink / raw)
To: Wei Yongjun
Cc: dwmw2, grant.likely, rob.herring, artem.bityutskiy, josh.wu,
plagnioj, jg1.han, devicetree, yongjun_wei, linux-mtd
On Fri, Aug 23, 2013 at 10:50:36AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-24 4:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23 2:50 [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe() Wei Yongjun
2013-08-23 3:53 ` Josh Wu
2013-08-23 3:54 ` Josh Wu
2013-08-24 4:44 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).