* [PATCH -next] dma: cppi41: fix error return code in cppi41_dma_probe()
@ 2013-08-23 2:59 Wei Yongjun
2013-08-26 8:30 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-08-23 2:59 UTC (permalink / raw)
To: vinod.koul, djbw, grant.likely, rob.herring
Cc: yongjun_wei, linux-kernel, devicetree
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return -EINVAL in the irq parse and map error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/dma/cppi41.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 5dcebca..49ea05a 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma/cppi41.c
@@ -973,8 +973,10 @@ static int cppi41_dma_probe(struct platform_device *pdev)
goto err_chans;
irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
- if (!irq)
+ if (!irq) {
+ ret = -EINVAL;
goto err_irq;
+ }
cppi_writel(USBSS_IRQ_PD_COMP, cdd->usbss_mem + USBSS_IRQ_ENABLER);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] dma: cppi41: fix error return code in cppi41_dma_probe()
2013-08-23 2:59 [PATCH -next] dma: cppi41: fix error return code in cppi41_dma_probe() Wei Yongjun
@ 2013-08-26 8:30 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2013-08-26 8:30 UTC (permalink / raw)
To: Wei Yongjun, Felipe Balbi
Cc: djbw, grant.likely, rob.herring, yongjun_wei, linux-kernel,
devicetree
On Fri, Aug 23, 2013 at 10:59:15AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -EINVAL in the irq parse and map error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
This need to go thru USB tree
Acked-by Vinod Koul <vinod.koul@intel.com>
~Vinod
> ---
> drivers/dma/cppi41.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
> index 5dcebca..49ea05a 100644
> --- a/drivers/dma/cppi41.c
> +++ b/drivers/dma/cppi41.c
> @@ -973,8 +973,10 @@ static int cppi41_dma_probe(struct platform_device *pdev)
> goto err_chans;
>
> irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
> - if (!irq)
> + if (!irq) {
> + ret = -EINVAL;
> goto err_irq;
> + }
>
> cppi_writel(USBSS_IRQ_PD_COMP, cdd->usbss_mem + USBSS_IRQ_ENABLER);
>
>
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-26 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23 2:59 [PATCH -next] dma: cppi41: fix error return code in cppi41_dma_probe() Wei Yongjun
2013-08-26 8:30 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).