From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pratyush Anand Subject: Re: [PATCH V2] PCI: exynos: add support for MSI Date: Thu, 29 Aug 2013 09:15:08 +0530 Message-ID: <20130829034508.GA3025@pratyush-vbox> References: <003d01ce9fc6$9c0f1c20$d42d5460$%han@samsung.com> <20130823083539.GB3937@pratyush-vbox> <001801cea3c7$06bca9d0$1435fd70$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <001801cea3c7$06bca9d0$1435fd70$%han@samsung.com> Sender: linux-pci-owner@vger.kernel.org To: Jingoo Han Cc: 'Bjorn Helgaas' , "linux-pci@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , 'Kukjin Kim' , Mohit KUMAR DCG , 'Siva Reddy Kallam' , 'SRIKANTH TUMKUR SHIVANAND' , 'Arnd Bergmann' , 'Sean Cross' , 'Kishon Vijay Abraham I' , 'Thierry Reding' , 'Thomas Petazzoni' , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Wed, Aug 28, 2013 at 04:17:24PM +0800, Jingoo Han wrote: > On Friday, August 23, 2013 5:36 PM, Pratyush Anand wrote: > > On Fri, Aug 23, 2013 at 02:04:20PM +0800, Jingoo Han wrote: > [...] > > #define MAX_PCIE_PORT_SUPPORTED 3 > > static DECLARE_BITMAP(msi_irq_in_use[MAX_PCIE_PORT_SUPPORTED], > > NUM_MSI_IRQS); > > static unsigned int *msi_data[MAX_PCIE_PORT_SUPPORTED]; > > No, there is no need to do it. > Without this, we can use 3 RCs by adding a node of 3rd RC to dt file. > Yes, you can use RCs by adding nodes to dt file. But you will need one msi_irq_in_use and one msi_data per RC (ie per port in this driver), isn't it? Regards Pratyush