From: Dan Carpenter <dan.carpenter@oracle.com>
To: Duan Fugang-B38611 <B38611@freescale.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
"David S. Miller" <davem@davemloft.net>,
Estevam Fabio-R49496 <r49496@freescale.com>,
Li Frank-B20596 <B20596@freescale.com>,
Jim Baxter <jim_baxter@mentor.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch v2] net/fec: cleanup types in fec_get_mac()
Date: Fri, 30 Aug 2013 12:00:49 +0300 [thread overview]
Message-ID: <20130830090049.GJ19256@mwanda> (raw)
In-Reply-To: <9848F2DB572E5649BA045B288BE08FBE01662A4B@039-SN2MPN1-021.039d.mgd.msft.net>
On Fri, Aug 30, 2013 at 02:02:00AM +0000, Duan Fugang-B38611 wrote:
> From: Ben Hutchings [mailto:bhutchings@solarflare.com]
> Data: Friday, August 30, 2013 2:49 AM
>
> > To: Dan Carpenter
> > Cc: Grant Likely; Rob Herring; David S. Miller; Estevam Fabio-R49496; Li
> > Frank-B20596; Jim Baxter; Duan Fugang-B38611; netdev@vger.kernel.org;
> > devicetree@vger.kernel.org; kernel-janitors@vger.kernel.org
> > Subject: Re: [patch v2] net/fec: cleanup types in fec_get_mac()
> >
> > On Thu, 2013-08-29 at 11:25 +0300, Dan Carpenter wrote:
> > > My static checker complains that on some arches unsigned longs can be
> > > 8 characters which is larger than the buffer is only 6 chars.
> > > Additionally, Ben Hutchings points out that the buffer actually holds
> > > big endian data and the buffer we are reading from is CPU endian.
> >
> > It's not really as clear-cut as that. :-) But I think it's slightly more
> > logical this way.
> >
> Yes, it is not clear, pls remove somebody's name from the commit log.
Huh? No, I'm going to leave Ben's name as is. It's weird that you
would ask for that.
regards,
dan carpenter
next prev parent reply other threads:[~2013-08-30 9:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:49 [patch] net/fec: "u32" is more explicit than "unsigned long" Dan Carpenter
2013-08-23 12:44 ` Ben Hutchings
2013-08-27 18:51 ` David Miller
2013-08-27 18:59 ` Dan Carpenter
2013-08-29 8:25 ` [patch v2] net/fec: cleanup types in fec_get_mac() Dan Carpenter
2013-08-29 18:48 ` Ben Hutchings
2013-08-30 2:02 ` Duan Fugang-B38611
2013-08-30 9:00 ` Dan Carpenter [this message]
2013-08-30 21:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830090049.GJ19256@mwanda \
--to=dan.carpenter@oracle.com \
--cc=B20596@freescale.com \
--cc=B38611@freescale.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jim_baxter@mentor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=r49496@freescale.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).