From: Mark Rutland <mark.rutland@arm.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"jic23@cam.ac.uk" <jic23@cam.ac.uk>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org"@arm.com
Subject: Re: [PATCH] Documentation: dt: i2c: Add LPS001WP to the Trivial Devices list
Date: Wed, 4 Sep 2013 15:24:22 +0100 [thread overview]
Message-ID: <20130904142422.GM18206@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1378302655-13258-1-git-send-email-lee.jones@linaro.org>
Hi Lee,
Cheers for producing a binding.
On Wed, Sep 04, 2013 at 02:50:55PM +0100, Lee Jones wrote:
> LPS001WP is a Pressure and Temperature sensor.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> index ad6a738..6038807e6 100644
> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> @@ -57,6 +57,7 @@ st-micro,24c256 i2c serial eeprom (24cxx)
> stm,m41t00 Serial Access TIMEKEEPER
> stm,m41t62 Serial real-time clock (RTC) with alarm
> stm,m41t80 M41T80 - SERIAL ACCESS RTC WITH ALARMS
> +stm,lps001wp Pressure and Temperature sensor
As I hinted at in the other thread [1], I don't think this can be
documented as a trivial binding -- the driver expects a couple of
regulators which should be described in the binding (or the driver
shouldn't be using them...).
Also, in the other thread the "st," prefix was used [2], while "stm," is
listed at the prefix in the binding. As far as I can see, "st," should
be used, as it's in vendor-prefixes and "stm," is not.
I'm happy to cook up a patch adding deprecation notes and corrected
strings for the existing incorrect "stm," bindings.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/196561.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/196558.html
Thanks,
Mark.
> taos,tsl2550 Ambient Light Sensor with SMBUS/Two Wire Serial Interface
> ti,tsc2003 I2C Touch-Screen Controller
> ti,tmp102 Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> --
> 1.8.1.2
>
>
next parent reply other threads:[~2013-09-04 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1378302655-13258-1-git-send-email-lee.jones@linaro.org>
2013-09-04 14:24 ` Mark Rutland [this message]
[not found] ` <20130904151159.GA8980@lee--X1>
2013-09-05 11:30 ` [PATCH] Documentation: dt: i2c: Add LPS001WP to the Trivial Devices list Mark Rutland
[not found] ` <20130905113001.GR18206-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-09-05 11:40 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904142422.GM18206@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc="devicetree@vger.kernel.org"@arm.com \
--cc=jic23@cam.ac.uk \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).