From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [RFC PATCH] dt: add a binding review checklist
Date: Fri, 6 Sep 2013 10:09:02 +0200 [thread overview]
Message-ID: <20130906100902.13eb3c7a@skate> (raw)
In-Reply-To: <20130905111918.GQ18206@e106331-lin.cambridge.arm.com>
Mark, Stephen,
On Thu, 5 Sep 2013 12:19:18 +0100, Mark Rutland wrote:
> > +Compatible Property
> > +-------------------
> > +
> > +A compatible value identifies a hardware module. It needs to identify the
> > +vendor (e.g. NVIDIA), type or name of device (e.g. I2C), and version of the
> > +device (e.g. an IP block version number or chip name). The following formats
> > +of compatible value are acceptable:
> > +
> > +* ${vendor},${device}-${version} (e.g. ti,omap4-i2c)
> > +* ${vendor},${version}-${device} (e.g. nvidia,tegra20-i2c)
> > +* ${vendor},${device}-${version} (e.g. synopsis,dwc3)
>
> It would be nice to make it clear that the compatible string for a
> device should (wherever possible) be the name of the specific IP block,
> which isn't completely clear above (e.g. "arm,pl011" is preferred to
> "arm,vexpress-v2m-serial"). It would be nice if we could avoid examples
> with SoC names for this reason.
>
> Obviously there will be SoC-specific devices that will have SoC names in
> their bindings. But those bindings should be considered carefully.
I agree that it would be nice to make it clear that using the name of
an SoC family in the compatible string is not a good idea, and that
instead the name of the particular SoC that originally introduced the
IP block should be used. I.e nvidia,tegra20-i2c is fine, but
nvidia,tegra-i2c is not, because we have no idea what I2C controllers
will be used on future Tegra SoCs.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-06 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 22:42 [RFC PATCH] dt: add a binding review checklist Stephen Warren
2013-09-05 11:19 ` Mark Rutland
2013-09-05 21:35 ` Stephen Warren
2013-09-06 10:50 ` Mark Rutland
2013-09-06 19:49 ` Stephen Warren
2013-09-06 8:09 ` Thomas Petazzoni [this message]
2013-09-06 9:14 ` Sebastian Hesselbarth
2013-09-06 19:38 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906100902.13eb3c7a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=Pawel.Moll@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=mark.rutland@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).