From: Josh Cartwright <joshc@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Rohit Vaswani <rvaswani@codeaurora.org>,
David Brown <davidb@codeaurora.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Russell King <linux@arm.linux.org.uk>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] ARM: msm: Remove irqs-*.h files for DT based targets
Date: Fri, 6 Sep 2013 15:55:38 -0500 [thread overview]
Message-ID: <20130906205538.GK808@joshc.qualcomm.com> (raw)
In-Reply-To: <1378499517-24014-1-git-send-email-sboyd@codeaurora.org>
On Fri, Sep 06, 2013 at 01:31:57PM -0700, Stephen Boyd wrote:
> We don't want or need the irqs.h files from the DT based MSM
> targets. Remove these header files and select sparse irq so that
> we don't try to include the mach/irqs.h file.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> On 09/06, Josh Cartwright wrote:
> >
> > Selecting _only_ ARCH_MSM8974 with these changes breaks the build with:
>
> I've been meaning to fix this. Perhaps you can use this patch as a base
> and then push the SPARSE_IRQ selection into the DT config?
Sounds sane to me. AFAICT, we didn't yet have any users of these
defines upstream. Using SPARSE_IRQ puts on the path of multiplatform
support anyway.
FWIW, I tested this by applying this change under Rohit's and squashing
the following with patch 1/2:
diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig
index fe35acf..f4a0aaa 100644
--- a/arch/arm/mach-msm/Kconfig
+++ b/arch/arm/mach-msm/Kconfig
@@ -50,7 +50,6 @@ config ARCH_MSM8X60
select HAVE_SMP
select MSM_SCM if SMP
select USE_OF
- select SPARSE_IRQ
config ARCH_MSM8960
bool "MSM8960"
@@ -60,7 +59,6 @@ config ARCH_MSM8960
select GPIO_MSM_V2
select MSM_SCM if SMP
select USE_OF
- select SPARSE_IRQ
config ARCH_MSM8974
bool "MSM8974"
@@ -74,6 +72,7 @@ config ARCH_MSM8974
config ARCH_MSM_DT
def_bool y
depends on (ARCH_MSM8X60 || ARCH_MSM8960 || ARCH_MSM8974)
+ select SPARSE_IRQ
config MSM_HAS_DEBUG_UART_HS
bool
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-09-06 20:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 19:32 [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard Rohit Vaswani
2013-09-06 19:53 ` Josh Cartwright
2013-09-06 20:31 ` [PATCH] ARM: msm: Remove irqs-*.h files for DT based targets Stephen Boyd
2013-09-06 20:50 ` Stephen Boyd
2013-09-06 20:55 ` Josh Cartwright [this message]
2013-09-06 21:50 ` [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard Olof Johansson
2013-09-09 17:48 ` Rohit Vaswani
2013-09-09 19:17 ` Kumar Gala
2013-09-09 19:29 ` Stephen Warren
2013-09-09 19:48 ` Kumar Gala
2013-09-09 21:21 ` Stephen Warren
2013-09-09 21:25 ` Kumar Gala
2013-09-09 21:42 ` Rohit Vaswani
2013-09-09 22:04 ` Kumar Gala
2013-09-09 22:30 ` Rohit Vaswani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906205538.GK808@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dwalker@fifo99.com \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rvaswani@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).