From: Thierry Reding <thierry.reding@gmail.com>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: r65073@freescale.com, grant.likely@linaro.org,
linux@arm.linux.org.uk, rob@landley.net, ian.campbell@citrix.com,
swarren@wwwdotorg.org, mark.rutland@arm.com, pawel.moll@arm.com,
rob.herring@calxeda.com, linux-arm-kernel@lists.infradead.org,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Jingchang Lu <b35083@freescale.com>
Subject: Re: [PATCHv3 1/4] pwm: Add Freescale FTM PWM driver support
Date: Mon, 9 Sep 2013 14:20:09 +0200 [thread overview]
Message-ID: <20130909122008.GC22197@ulmo> (raw)
In-Reply-To: <1378454907-22728-2-git-send-email-Li.Xiubo@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
On Fri, Sep 06, 2013 at 04:08:24PM +0800, Xiubo Li wrote:
> The FTM PWM device can be found on Vybrid VF610 Tower and Layerscape LS-1 SoCs.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> Signed-off-by: Jingchang Lu <b35083@freescale.com>
> ---
> drivers/pwm/Kconfig | 10 +
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-fsl-ftm.c | 505 ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 516 insertions(+)
> create mode 100644 drivers/pwm/pwm-fsl-ftm.c
This looks pretty good to me. I noticed that you didn't Cc Sascha who
commented on this a lot. Can you please resend with him Cc'ed to make
sure he sees this version of the series?
One thing jumped out at me, so I've commented on it below, but I will go
over the patch more carefully after you resend.
[...]
> diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c
[...]
> +static int fsl_counter_clock_enable(struct fsl_pwm_chip *fpc)
> +{
[...]
> + switch (fpc->counter_clk_select) {
> + case FSL_COUNTER_CLK_SYS:
> + reg |= FTMSC_CLKSYS;
> + break;
> + case FSL_COUNTER_CLK_FIX:
> + reg |= FTMSC_CLKFIX;
> + break;
> + case FSL_COUNTER_CLK_EXT:
> + ret |= FTMSC_CLKEXT;
s/ret/reg/
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-09 12:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 8:08 [PATCHv3 0/4] Add Freescale FTM PWM driver Xiubo Li
2013-09-06 8:08 ` [PATCHv3 1/4] pwm: Add Freescale FTM PWM driver support Xiubo Li
2013-09-09 12:20 ` Thierry Reding [this message]
2013-09-09 15:03 ` Sascha Hauer
2013-09-10 2:35 ` Xiubo Li-B47053
2013-09-10 6:51 ` Sascha Hauer
2013-09-10 8:12 ` Xiubo Li-B47053
2013-09-06 8:08 ` [PATCHv3 2/4] ARM: dts: Add Freescale FTM PWM node for VF610 Xiubo Li
2013-09-10 6:40 ` Sascha Hauer
2013-09-10 8:10 ` Xiubo Li-B47053
2013-09-06 8:08 ` [PATCHv3 3/4] ARM: dts: Enables FTM PWM device for Vybrid VF610 TOWER board Xiubo Li
2013-09-06 8:08 ` [PATCHv3 4/4] Documentation: Add device tree bindings for Freescale FTM PWM Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909122008.GC22197@ulmo \
--to=thierry.reding@gmail.com \
--cc=Li.Xiubo@freescale.com \
--cc=b35083@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=r65073@freescale.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).