From: Sascha Hauer <s.hauer@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: devicetree@vger.kernel.org, Fugang Duan <B38611@freescale.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] ARM: dts: add fec phy reset for imx6sl evk board
Date: Mon, 9 Sep 2013 17:00:24 +0200 [thread overview]
Message-ID: <20130909150024.GU30088@pengutronix.de> (raw)
In-Reply-To: <20130909145333.GA5815@S2101-09.ap.freescale.net>
On Mon, Sep 09, 2013 at 10:53:36PM +0800, Shawn Guo wrote:
> On Tue, Sep 03, 2013 at 12:26:23PM +0800, Fugang Duan wrote:
> > Add fec phy gpio reset for imx6sl evk board. imx6sl evk board
> > use GPIO4_21 to do phy reset, so add phy-reset-gpios and
> > phy-reset-duration propery initial for fec device node.
> >
> > Signed-off-by: Fugang Duan <B38611@freescale.com>
>
> I have to drop this patch for now, because it causes a regression for
> me.
>
> Before this patch, we can at least get a working fec driver in kernel if
> U-Boot sets it up properly, e.g. we download kernel from network. But
> with the patch, the fec driver stops working on linux-next in the same
> use case.
I think the FEC driver has doesn't wait enough time after it deasserts
the phy reset before it accesses the phy. At least I once got the
impression, but I haven't digged deeper so far.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-09-09 15:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 4:26 [PATCH v2 0/4] *** ARM: imx6sl: add FEC support for imx6sl evk platform *** Fugang Duan
2013-09-03 4:26 ` [PATCH v2 1/4] ARM: dts: add iomuxc-gpr device node for imx6sl Fugang Duan
2013-09-04 13:23 ` Shawn Guo
2013-09-03 4:26 ` [PATCH v2 2/4] ARM: dts: add fec phy reset for imx6sl evk board Fugang Duan
2013-09-09 14:53 ` Shawn Guo
2013-09-09 15:00 ` Sascha Hauer [this message]
2013-09-10 1:26 ` Duan Fugang-B38611
2013-09-10 3:11 ` Shawn Guo
2013-09-10 3:23 ` Duan Fugang-B38611
2013-09-10 3:34 ` Shawn Guo
2013-09-03 4:26 ` [PATCH v2 3/4] ARM: imx6sl: add imx6sl iomux-gpr field define Fugang Duan
2013-09-05 1:44 ` Otavio Salvador
2013-09-05 2:01 ` Duan Fugang-B38611
2013-09-05 2:04 ` Otavio Salvador
2013-09-03 4:26 ` [PATCH v2 4/4] ARM: imx6sl: config iomux-gpr1 to select clock for fec Fugang Duan
2013-09-04 13:19 ` [PATCH v2 0/4] *** ARM: imx6sl: add FEC support for imx6sl evk platform *** Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909150024.GU30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=B38611@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).