From: Thierry Reding <thierry.reding@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Marek Vasut <marex@denx.de>,
linux-pwm@vger.kernel.org, Mike Dunn <mikedunn@newsguy.com>,
Pawel Moll <pawel.moll@arm.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
devicetree@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
Chao Xie <chao.xie@marvell.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-arm-kernel@lists.infradead.org,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [RESEND PATCH v2] pwm: pxa: add device tree support to pwm driver
Date: Tue, 10 Sep 2013 18:54:46 +0200 [thread overview]
Message-ID: <20130910165445.GA22111@ulmo> (raw)
In-Reply-To: <522F4CF9.3070601@wwwdotorg.org>
[-- Attachment #1.1: Type: text/plain, Size: 1211 bytes --]
On Tue, Sep 10, 2013 at 10:46:49AM -0600, Stephen Warren wrote:
> On 09/10/2013 09:54 AM, Mike Dunn wrote:
> > On 09/09/2013 02:19 PM, Stephen Warren wrote:
> >> On 09/09/2013 12:30 PM, Mike Dunn wrote:
[...]
> >>> +- reg: physical base address and length of the registers used by the pwm channel
> >>> + NB: One device instance must be created for each pwm that is used, so the
> >>> + length covers only the register window for one pwm output, not that of the
> >>> + entire pwm controller. Currently length is 0x10 for all supported devices.
> >>> +- #pwm-cells: should be 3.
> >>> + cell 1: the per-chip index of the PWM to use,
> >>
> >> That cell shouldn't be needed if you really want to have one DT node per
> >> PWM channel.
> >
> > Yes, but I was afraid to deviate from the format used by the other PWM
> > controllers. (But in that case, it should at least be documented as "must be
> > zero". Thanks.) If going my owm way is acceptable, I'll define my own
> > of_xlate() parser and remove this cell.
>
> I don't think there's any issue with deviating; that's exactly what
> #pwm-cells is for.
Agreed, I have no objections to using a custom .of_xlate().
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2013-09-10 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 18:30 [RESEND PATCH v2] pwm: pxa: add device tree support to pwm driver Mike Dunn
2013-09-09 21:19 ` Stephen Warren
2013-09-10 15:54 ` Mike Dunn
2013-09-10 16:46 ` Stephen Warren
2013-09-10 16:54 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910165445.GA22111@ulmo \
--to=thierry.reding@gmail.com \
--cc=chao.xie@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=mikedunn@newsguy.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=robert.jarzmik@free.fr \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).