From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: tpmdd-devel@lists.sourceforge.net,
Teddy Reed <teddy@prosauce.org>,
Teddy Reed <teddy.reed@gmail.com>,
Leonidas Da Silva Barbosa <leosilva@linux.vnet.ibm.com>,
Ashley Lai <ashley@ashleylai.com>,
Rajiv Andrade <mail@srajiv.net>,
Peter Huewe <peter.huewe@infineon.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] tpm: Add support for Atmel I2C TPMs
Date: Wed, 11 Sep 2013 17:08:41 -0600 [thread overview]
Message-ID: <20130911230841.GB4251@obsidianresearch.com> (raw)
In-Reply-To: <20130911205807.GA21467@obsidianresearch.com>
On Wed, Sep 11, 2013 at 02:58:07PM -0600, Jason Gunthorpe wrote:
> I'm not yet 100% certain this driver works perfectly, for some reason
> my TPM will not create an EK, which is either due to a larger sent TPM
> messages becoming corrupt (combined with a TPM bug to not report an
> error code) or something wrong with the TPM itself.
> +
> + status = i2c_smbus_write_i2c_block_data(client, buf[0], len - 1,
> + buf + 1);
Thankfully Peter pointed out that these calls only transfer 32 bytes,
which causes the problem I observed. The TPM returns success with a
corrupted response when you truncate the request, apparently.
Fixing it with:
+ status = i2c_master_send(client, buf, len);
Has the driver pass all my tests. I will post a v1 after a few days
and collect any other comments.
Jason
next prev parent reply other threads:[~2013-09-11 23:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 20:58 [PATCH] tpm: Add support for Atmel I2C TPMs Jason Gunthorpe
2013-09-11 22:44 ` [tpmdd-devel] " Peter Hüwe
2013-09-11 23:08 ` Jason Gunthorpe [this message]
2013-09-11 23:23 ` Peter Hüwe
2013-09-11 23:52 ` Peter Hüwe
[not found] ` <201309120152.36878.PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
2013-09-17 23:56 ` Jason Gunthorpe
[not found] ` <CADUykeorCx+YY1mF4DazXAmmnS=ocjdxeT2mHRsRxmJv04LFSQ@mail.gmail.com>
[not found] ` <CADUykeorCx+YY1mF4DazXAmmnS=ocjdxeT2mHRsRxmJv04LFSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-01 18:00 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911230841.GB4251@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=ashley@ashleylai.com \
--cc=devicetree@vger.kernel.org \
--cc=leosilva@linux.vnet.ibm.com \
--cc=mail@srajiv.net \
--cc=peter.huewe@infineon.com \
--cc=teddy.reed@gmail.com \
--cc=teddy@prosauce.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).