devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: tpmdd-devel@lists.sourceforge.net
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Teddy Reed <teddy@prosauce.org>,
	Teddy Reed <teddy.reed@gmail.com>,
	Leonidas Da Silva Barbosa <leosilva@linux.vnet.ibm.com>,
	Ashley Lai <ashley@ashleylai.com>,
	Rajiv Andrade <mail@srajiv.net>,
	Peter Huewe <peter.huewe@infineon.com>,
	devicetree@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm: Add support for Atmel I2C TPMs
Date: Thu, 12 Sep 2013 00:44:29 +0200	[thread overview]
Message-ID: <201309120044.30003.PeterHuewe@gmx.de> (raw)
In-Reply-To: <20130911205807.GA21467@obsidianresearch.com>

Am Mittwoch, 11. September 2013, 22:58:07 schrieb Jason Gunthorpe:
> This is based on the work of Teddy Reed <teddy@prosauce.org> published
> on GitHub:
>  https://github.com/theopolis/tpm-i2c-atmel.git
>  34894b988b67e0ae55088d6388e77b0dbf10c07d
> 
> That driver was never merged, I have taken it as a starting point,
> forward ported, tested and revised the driver:
>  - Make it broadly textually similar to the Infineon and Nuvoton I2C
>    driver
>  - Place everything in a format suitable for mainline inclusion
>  - Use high level I2C functions i2c_smbus_write_i2c_block_data and
>    i2c_master_recv for data xfer
>  - Use the timeout system from the core code, by faking out a status
>    register
>  - checkpatch cleanups
>  - Testing on ARM Kirkwood, with this device tree, using a
>    AT97SC3204T-X1A180
>         tpm@29 {
>                 compatible = "atmel,at97sc3204t";
>                 reg = <0x29>;
>         };
> 
> PENDING: Teddy will need to provide a Signed-Off line for this driver,
> although very little of his original text remained unchanged, the
> work to discover the protocol is entirely his and he will need to
> certify the Developer Certification of Origin that it is suitable
> for mainline inclusion.
> 
> [jgg: revised and tested]
> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>


Hi Jason,

thanks for porting yet another driver.
I think I'll stage them (nuvoton, st and atmel) all in a temporary branch 
"testing-and-review" so it's easier for people to try them out.

Thanks,
Peter

  reply	other threads:[~2013-09-11 23:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 20:58 [PATCH] tpm: Add support for Atmel I2C TPMs Jason Gunthorpe
2013-09-11 22:44 ` Peter Hüwe [this message]
2013-09-11 23:08 ` Jason Gunthorpe
2013-09-11 23:23   ` [tpmdd-devel] " Peter Hüwe
2013-09-11 23:52     ` Peter Hüwe
     [not found]       ` <201309120152.36878.PeterHuewe-Mmb7MZpHnFY@public.gmane.org>
2013-09-17 23:56         ` Jason Gunthorpe
     [not found] ` <CADUykeorCx+YY1mF4DazXAmmnS=ocjdxeT2mHRsRxmJv04LFSQ@mail.gmail.com>
     [not found]   ` <CADUykeorCx+YY1mF4DazXAmmnS=ocjdxeT2mHRsRxmJv04LFSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-01 18:00     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309120044.30003.PeterHuewe@gmx.de \
    --to=peterhuewe@gmx.de \
    --cc=ashley@ashleylai.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=leosilva@linux.vnet.ibm.com \
    --cc=mail@srajiv.net \
    --cc=peter.huewe@infineon.com \
    --cc=teddy.reed@gmail.com \
    --cc=teddy@prosauce.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).