From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v3 1/4] mfd: add LP3943 MFD driver
Date: Thu, 12 Sep 2013 16:40:00 +0100
Message-ID: <20130912154000.GP11227@lee--X1>
References: <1378949524-6143-1-git-send-email-milo.kim@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1378949524-6143-1-git-send-email-milo.kim@ti.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Milo Kim <milo.kim@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Thierry Reding <thierry.reding@gmail.com>
List-Id: devicetree@vger.kernel.org

On Thu, 12 Sep 2013, Milo Kim wrote:

> LP3943 has 16 output pins which can be used as GPIO expander and PWM =
generator.
>=20
> * Regmap I2C interface for R/W LP3943 registers
>=20
> * Atomic operations for output pin assignment
>   The driver should check whether requested pin is available or not.
>   If the pin is already used, pin request returns as a failure.
>   A driver data, 'pin_used' is checked when gpio_request() and
>   pwm_request() are called. If the pin is available, then pin_used is=
 set.
>   And it is cleared when gpio_free() and pwm_free().
>=20
> * Device tree support
>   Compatible strings for GPIO and PWM driver.
>   LP3943 platform data is PWM related, so parsing the device tree is
>   implemented in the PWM driver.
>=20
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Milo Kim <milo.kim@ti.com>
> ---
> * Patch v3
>   Now, output pin number is exactly matched with enum value of '
>   lp3943_pwm_output'.
>   Use dev_get_platdata() helper function in probe().
>   Use module_i2c_driver() for initcall.
>=20
> * Patch v2
>   Handle atomic operations for output pin assignment.
>=20
>  drivers/mfd/Kconfig        |   11 ++++
>  drivers/mfd/Makefile       |    1 +
>  drivers/mfd/lp3943.c       |  148 ++++++++++++++++++++++++++++++++++=
++++++++++
>  include/linux/mfd/lp3943.h |  114 ++++++++++++++++++++++++++++++++++
>  4 files changed, 274 insertions(+)
>  create mode 100644 drivers/mfd/lp3943.c
>  create mode 100644 include/linux/mfd/lp3943.h

Code looks good to me. For the MFD parts:

Acked-by: Lee Jones <lee.jones@linaro.org>

--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
=46ollow Linaro: Facebook | Twitter | Blog