[PATCH v3 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

[PATCH v3 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

[Milo Kim]

LP3943 is an integrated device capable of driving 16 output channels.
It can be used for GPIO expander and PWM generators.
LP3493 registers are controlled via the I2C interface.

This patch-set consists of four parts - MFD, GPIO, PWM and documents.

Major updates in v3:

* MFD
  Lee Jones pointed confusing pin number notation.
  Now, each output pin number is exactly matched to each enum value.

  LP3943 has a static configuration from platform data or the device tree,
  So, I keep the driver structure instead of using the pin control subsystem.
  (https://lkml.org/lkml/2013/8/14/490)

* PWM
  Do not emulate 'set_polarity' function in case of unsupported feature by
  the chip.
  Code fixes based on Thierry Reding's comments.
  (https://lkml.org/lkml/2013/8/14/188)

* Documentation
  From Thierry's suggestion, detailed driver description was moved to
  'Documentation/lp3943.txt'.
  Fix device tree bindings from maintainers' comments.
  (https://lkml.org/lkml/2013/7/31/226)
  (https://lkml.org/lkml/2013/8/14/569)

Milo Kim (4):
  mfd: add LP3943 MFD driver
  gpio: add LP3943 I2C GPIO expander driver
  pwm: add LP3943 PWM driver
  Documentation: add LP3943 DT bindings and document

 Documentation/00-INDEX                             |    2 +
 .../devicetree/bindings/gpio/gpio-lp3943.txt       |   37 +++
 Documentation/devicetree/bindings/mfd/lp3943.txt   |   33 ++
 .../devicetree/bindings/pwm/pwm-lp3943.txt         |   58 ++++
 Documentation/lp3943.txt                           |   62 ++++
 drivers/gpio/Kconfig                               |    8 +
 drivers/gpio/Makefile                              |    1 +
 drivers/gpio/gpio-lp3943.c                         |  242 +++++++++++++++
 drivers/mfd/Kconfig                                |   11 +
 drivers/mfd/Makefile                               |    1 +
 drivers/mfd/lp3943.c                               |  148 +++++++++
 drivers/pwm/Kconfig                                |   10 +
 drivers/pwm/Makefile                               |    1 +
 drivers/pwm/pwm-lp3943.c                           |  314 ++++++++++++++++++++
 include/linux/mfd/lp3943.h                         |  114 +++++++
 15 files changed, 1042 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-lp3943.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/lp3943.txt
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-lp3943.txt
 create mode 100644 Documentation/lp3943.txt
 create mode 100644 drivers/gpio/gpio-lp3943.c
 create mode 100644 drivers/mfd/lp3943.c
 create mode 100644 drivers/pwm/pwm-lp3943.c
 create mode 100644 include/linux/mfd/lp3943.h

-- 
1.7.9.5

Re: [PATCH v3 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

[Lee Jones]

> * Documentation
>   From Thierry's suggestion, detailed driver description was moved to
>   'Documentation/lp3943.txt'.

Really? Why here? Do we really want 1000's of driver docs in /Documentation?

No other driver does this (intel gained from a glancing look).

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

On Thu, Sep 12, 2013 at 04:28:09PM +0100, Lee Jones wrote:
> > * Documentation
> >   From Thierry's suggestion, detailed driver description was moved to
> >   'Documentation/lp3943.txt'.
> 
> Really? Why here? Do we really want 1000's of driver docs in /Documentation?
> 
> No other driver does this (intel gained from a glancing look).

Well, perhaps the top-level Documentation directory isn't optimal, but I
think it's a lot better than the commit description. Perhaps an 'mfd'
subdirectory could be created where documentation such as this could be
put.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH v3 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

[Milo Kim]

Hi Lee,

On 09/15/2013 08:17 PM, Thierry Reding wrote:
> On Thu, Sep 12, 2013 at 04:28:09PM +0100, Lee Jones wrote:
>>> * Documentation
>>>    From Thierry's suggestion, detailed driver description was moved to
>>>    'Documentation/lp3943.txt'.
>>
>> Really? Why here? Do we really want 1000's of driver docs in /Documentation?

There is no subdirectory for GPIO and PWM documents under 'Documentation'.
That's why I put LP3943 documentation here.

>> No other driver does this (intel gained from a glancing look).

I thought it's no issue because I still found few driver documentations 
in that location.
It sounds like people are moving those into other subdirectories.
Thanks for this information.

> Well, perhaps the top-level Documentation directory isn't optimal, but I
> think it's a lot better than the commit description. Perhaps an 'mfd'
> subdirectory could be created where documentation such as this could be
> put.

I agree Thierry.
If you don't mind, can I create a MFD subdirectory with this patch-set 
in next version, v4?
Any other ideas are welcome.

Best regards,
Milo



--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/4] LP3943 MFD driver for a GPIO expander and a PWM generator

[Linus Walleij]

On Mon, Sep 16, 2013 at 12:47 AM, Milo Kim <milo.kim-l0cyMroinI0@public.gmane.org> wrote:

> I agree Thierry.
> If you don't mind, can I create a MFD subdirectory with this patch-set in
> next version, v4?

This seems like a good idea.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html