From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH] ARM: dts: Update arch timer node with clock frequency Date: Wed, 18 Sep 2013 11:23:19 +0100 Message-ID: <20130918102319.GF26737@e106331-lin.cambridge.arm.com> References: <1379499113-20342-1-git-send-email-yuvaraj.cd@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1379499113-20342-1-git-send-email-yuvaraj.cd-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yuvaraj Kumar C D Cc: "linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , Pawel Moll , "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org" , "ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org" , "t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , Yuvaraj Kumar C D , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Marc Zyngier List-Id: devicetree@vger.kernel.org [adding lakml] On Wed, Sep 18, 2013 at 11:11:53AM +0100, Yuvaraj Kumar C D wrote: > Without the "clock-frequency" property in arch timer node, could able > to see the below crash dump. Why does this cause the below crash specifically? What is CNTFRQ reading as? Your firmware or bootloader should set CNTFRQ -- setting the clock-frequency is a work-around for buggy firmware/bootloaders that should be avoided as far as possible. Is it not possible to fix your firmware or bootlaoder to set CNTFRQ? Thanks, Mark. > > [] (unwind_backtrace+0x0/0xf4) from [] (show_stack+0x10/0x14) > [] (show_stack+0x10/0x14) from [] (dump_stack+0x7c/0xb0) > [] (dump_stack+0x7c/0xb0) from [] (Ldiv0_64+0x8/0x18) > [] (Ldiv0_64+0x8/0x18) from [] (clockevents_config.part.2+0x1c/0x74) > [] (clockevents_config.part.2+0x1c/0x74) from [] (clockevents_config_and_register+0x20/0x2c) > [] (clockevents_config_and_register+0x20/0x2c) from [] (arch_timer_setup+0xa8/0x134) > [] (arch_timer_setup+0xa8/0x134) from [] (arch_timer_init+0x1f4/0x24c) > [] (arch_timer_init+0x1f4/0x24c) from [] (clocksource_of_init+0x34/0x58) > [] (clocksource_of_init+0x34/0x58) from [] (time_init+0x20/0x2c) > [] (time_init+0x20/0x2c) from [] (start_kernel+0x1e0/0x39c) > > Signed-off-by: Yuvaraj Kumar C D > --- > arch/arm/boot/dts/exynos5250.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 7d7cc77..668ce5d 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -96,6 +96,7 @@ > <1 14 0xf08>, > <1 11 0xf08>, > <1 10 0xf08>; > + clock-frequency = <24000000>; > }; > > mct@101C0000 { > -- > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html