Re: [PATCH v2] clk: si570: Add a driver for SI570 oscillators

[Guenter Roeck <linux@roeck-us.net>]

On Thu, Sep 19, 2013 at 01:59:38PM -0700, Sören Brinkmann wrote:
> On Thu, Sep 19, 2013 at 09:44:38AM -0700, Guenter Roeck wrote:
> > On Thu, Sep 19, 2013 at 09:01:01AM -0700, Sören Brinkmann wrote:
> > > On Thu, Sep 19, 2013 at 06:17:12AM -0700, Guenter Roeck wrote:
> > > > On Wed, Sep 18, 2013 at 03:43:38PM -0700, Soren Brinkmann wrote:
> [...]
> > > > > +	if (of_property_read_bool(client->dev.of_node,
> > > > > +				"temperature-stability-7ppm"))
> > > > > +		data->div_offset = SI570_DIV_OFFSET_7PPM;
> > > > > +
> > > > Just noticed that you dropped platform data support. Doesn't matter much for me
> > > > right now, but in my previous company we used the chip on an x86 system which
> > > > does not support devicetree. Would be nice to keep it and derive platform data
> > > > from devicetree data if provided, like other drivers do it.
> > > I'll look into this. The issue I have with that is, I can hardly test it
> > > since we only use this on Zynq which uses DT. So, I'd rather prefer to
> > > not include it unless somebody volunteers to test it.
> > > 
> > Fair enough. I can not test it myself anymore, and my previous employer
> > now has a strict non-contributions-to-linux policy, so I guess they won't
> > test it either or at least not publish any test results. Leave it out.
> > 
> > > > The 7ppm option is only relevant for si570/si751 and not supported on
> > > > si598/si599. You should mention that in the bindings document and check for it.
> > > Right, I'll add a note in the doc. And ignore it for devices this does
> > > not apply.
> > > 
> > I would bail out, but that is your call.
> Correct me if I'm wrong, but in general drivers do not test for
> unsupported properties. So, in case we have one of the supported 59x
> device, we should not test whether a (unsupported) property is present,
> just to fail in that case, IMHO.
> 
Ok with me if that is the accepted way of handling this condition.

Guenter