From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2] clk: si570: Add a driver for SI570 oscillators Date: Thu, 19 Sep 2013 14:11:12 -0700 Message-ID: <20130919211112.GA11537@roeck-us.net> References: <1379544219-23579-1-git-send-email-soren.brinkmann@xilinx.com> <20130919131712.GB24088@roeck-us.net> <6401b71c-8c18-4735-8b40-9692cd788336@VA3EHSMHS037.ehs.local> <20130919164438.GA7461@roeck-us.net> <86ee8eea-7a98-443b-a156-46f3db1f9678@CO1EHSMHS031.ehs.local> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <86ee8eea-7a98-443b-a156-46f3db1f9678@CO1EHSMHS031.ehs.local> Sender: linux-doc-owner@vger.kernel.org To: =?iso-8859-1?Q?S=F6ren?= Brinkmann Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Mike Turquette , Grant Likely , Sebastian Hesselbarth , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hyun Kwon List-Id: devicetree@vger.kernel.org On Thu, Sep 19, 2013 at 01:59:38PM -0700, S=F6ren Brinkmann wrote: > On Thu, Sep 19, 2013 at 09:44:38AM -0700, Guenter Roeck wrote: > > On Thu, Sep 19, 2013 at 09:01:01AM -0700, S=F6ren Brinkmann wrote: > > > On Thu, Sep 19, 2013 at 06:17:12AM -0700, Guenter Roeck wrote: > > > > On Wed, Sep 18, 2013 at 03:43:38PM -0700, Soren Brinkmann wrote= : > [...] > > > > > + if (of_property_read_bool(client->dev.of_node, > > > > > + "temperature-stability-7ppm")) > > > > > + data->div_offset =3D SI570_DIV_OFFSET_7PPM; > > > > > + > > > > Just noticed that you dropped platform data support. Doesn't ma= tter much for me > > > > right now, but in my previous company we used the chip on an x8= 6 system which > > > > does not support devicetree. Would be nice to keep it and deriv= e platform data > > > > from devicetree data if provided, like other drivers do it. > > > I'll look into this. The issue I have with that is, I can hardly = test it > > > since we only use this on Zynq which uses DT. So, I'd rather pref= er to > > > not include it unless somebody volunteers to test it. > > >=20 > > Fair enough. I can not test it myself anymore, and my previous empl= oyer > > now has a strict non-contributions-to-linux policy, so I guess they= won't > > test it either or at least not publish any test results. Leave it o= ut. > >=20 > > > > The 7ppm option is only relevant for si570/si751 and not suppor= ted on > > > > si598/si599. You should mention that in the bindings document a= nd check for it. > > > Right, I'll add a note in the doc. And ignore it for devices this= does > > > not apply. > > >=20 > > I would bail out, but that is your call. > Correct me if I'm wrong, but in general drivers do not test for > unsupported properties. So, in case we have one of the supported 59x > device, we should not test whether a (unsupported) property is presen= t, > just to fail in that case, IMHO. >=20 Ok with me if that is the accepted way of handling this condition. Guenter