From: David Gibson <david@gibson.dropbear.id.au>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Jon Loeliger <jdl@jdl.com>, Olof Johansson <olof@lixom.net>,
frowand.list@gmail.com, Tomasz Figa <tomasz.figa@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [dtc PATCH] Ensure all tests have matching reg and unit address
Date: Fri, 20 Sep 2013 08:52:32 +1000 [thread overview]
Message-ID: <20130919225232.GG3551@voom.redhat.com> (raw)
In-Reply-To: <523B3935.2090904@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]
On Thu, Sep 19, 2013 at 11:49:41AM -0600, Stephen Warren wrote:
> On 09/19/2013 06:18 AM, David Gibson wrote:
> > On Wed, Sep 18, 2013 at 02:23:02PM -0600, Stephen Warren wrote:
> >> From: Stephen Warren <swarren@nvidia.com>
> >>
> >> ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies that
> >> any node that has a reg property must include a unit address in
> >> its name with value matching the first entry in its reg property.
> >> Conversely, if a node does not have a reg property, the node name
> >> must not include a unit address.
> >>
> >> Adjust all the dtc test-cases to conform to this rule.
> >>
> >> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> >
> > Yeah, the testcase examples were built as purely syntactic
> > exercises without really considering dt content conventions.
> > Fixing them up is arguably unnnecessary, but certainly doesn't hurt
> > and makes them better as examples.
> >
> > Applied and pushed.
>
> Strange; I see that the git author field ended up as you rather than
> me. Did you need to apply the patch manually for some reason (if so,
> what did I do wrong?) or did something go wrong in the patch
> application process?
Oh, dammit. git citool did that when I added my S-o-b, and I forgot
to fix it up. I just patched it up and did a push -f, I hope not too
many people have pulled in the meantime :(.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-09-19 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 20:23 [dtc PATCH] Ensure all tests have matching reg and unit address Stephen Warren
2013-09-19 12:18 ` David Gibson
[not found] ` <20130919121818.GB3551-1s0os16eZneny3qCrzbmXA@public.gmane.org>
2013-09-19 17:49 ` Stephen Warren
2013-09-19 22:52 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919225232.GG3551@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=jdl@jdl.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).