* [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
@ 2013-09-20 17:38 Balaji T K
[not found] ` <1379698696-21945-1-git-send-email-balajitk-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Balaji T K @ 2013-09-20 17:38 UTC (permalink / raw)
To: bcousson-rdvid1DuHRBWk0Htik3J/w,
devicetree-u79uwXL29TY76Z2rM5mHXA
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, tony-4v6yS6AI5VpBDgjK7y7TUQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Balaji T K
correct mux mode for mmc1_cmd to detect eMMC on bone-black
Signed-off-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 56361ce..90ab56c 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -117,7 +117,7 @@
emmc_pins: pinmux_emmc_pins {
pinctrl-single,pins = <
0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */
- 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */
+ 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */
0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */
0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */
0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */
--
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1379698696-21945-1-git-send-email-balajitk-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd [not found] ` <1379698696-21945-1-git-send-email-balajitk-l0cyMroinI0@public.gmane.org> @ 2013-09-20 17:44 ` Felipe Balbi 2013-09-20 19:11 ` Nishanth Menon 1 sibling, 0 replies; 5+ messages in thread From: Felipe Balbi @ 2013-09-20 17:44 UTC (permalink / raw) To: Balaji T K Cc: bcousson-rdvid1DuHRBWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, tony-4v6yS6AI5VpBDgjK7y7TUQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r [-- Attachment #1: Type: text/plain, Size: 354 bytes --] On Fri, Sep 20, 2013 at 11:08:16PM +0530, Balaji T K wrote: > correct mux mode for mmc1_cmd to detect eMMC on bone-black > > Signed-off-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org> Tested on my BBB, I see that after this patch eMMC gets detected just fine: Tested-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd [not found] ` <1379698696-21945-1-git-send-email-balajitk-l0cyMroinI0@public.gmane.org> 2013-09-20 17:44 ` Felipe Balbi @ 2013-09-20 19:11 ` Nishanth Menon [not found] ` <523C9DE4.6040109-l0cyMroinI0@public.gmane.org> 1 sibling, 1 reply; 5+ messages in thread From: Nishanth Menon @ 2013-09-20 19:11 UTC (permalink / raw) To: Balaji T K, bcousson-rdvid1DuHRBWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, tony-4v6yS6AI5VpBDgjK7y7TUQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 09/20/2013 12:38 PM, Balaji T K wrote: > correct mux mode for mmc1_cmd to detect eMMC on bone-black > > Signed-off-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org> > --- > arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi > index 56361ce..90ab56c 100644 > --- a/arch/arm/boot/dts/am335x-bone-common.dtsi > +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi > @@ -117,7 +117,7 @@ > emmc_pins: pinmux_emmc_pins { > pinctrl-single,pins = < > 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */ > - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */ > + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */ > 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */ > 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */ > 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */ > is'nt this a common change? why is it "black only"? if it is so, then the pinmux should probably be spun off outside bone-common.dtsi into boneblack.dtsi perhaps? -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <523C9DE4.6040109-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd [not found] ` <523C9DE4.6040109-l0cyMroinI0@public.gmane.org> @ 2013-09-23 15:28 ` Balaji T K [not found] ` <52405E30.2020001-l0cyMroinI0@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Balaji T K @ 2013-09-23 15:28 UTC (permalink / raw) To: Nishanth Menon Cc: bcousson-rdvid1DuHRBWk0Htik3J/w, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, tony-4v6yS6AI5VpBDgjK7y7TUQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Saturday 21 September 2013 12:41 AM, Nishanth Menon wrote: > On 09/20/2013 12:38 PM, Balaji T K wrote: >> correct mux mode for mmc1_cmd to detect eMMC on bone-black >> >> Signed-off-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org> >> --- >> arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi >> index 56361ce..90ab56c 100644 >> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi >> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi >> @@ -117,7 +117,7 @@ >> emmc_pins: pinmux_emmc_pins { >> pinctrl-single,pins = < >> 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */ >> - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */ >> + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */ >> 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */ >> 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */ >> 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */ >> > is'nt this a common change? why is it "black only"? if it is so, then > the pinmux should probably be spun off outside bone-common.dtsi into > boneblack.dtsi perhaps? > It is applicable for add-on eMMC-cape for beagle bone white, so eMMC pinmux can remain in bone-common.dtsi. However I could test only on beagle bone black which has eMMC on board, since I don't have access to eMMC-cape -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <52405E30.2020001-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd [not found] ` <52405E30.2020001-l0cyMroinI0@public.gmane.org> @ 2013-09-24 2:24 ` Nishanth Menon 0 siblings, 0 replies; 5+ messages in thread From: Nishanth Menon @ 2013-09-24 2:24 UTC (permalink / raw) To: Balaji T K Cc: Tony Lindgren, dt list, linux-omap, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bcousson-rdvid1DuHRBWk0Htik3J/w On Mon, Sep 23, 2013 at 10:28 AM, Balaji T K <balajitk-l0cyMroinI0@public.gmane.org> wrote: > On Saturday 21 September 2013 12:41 AM, Nishanth Menon wrote: >> >> On 09/20/2013 12:38 PM, Balaji T K wrote: >>> >>> correct mux mode for mmc1_cmd to detect eMMC on bone-black >>> >>> Signed-off-by: Balaji T K <balajitk-l0cyMroinI0@public.gmane.org> >>> --- >>> arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi >>> b/arch/arm/boot/dts/am335x-bone-common.dtsi >>> index 56361ce..90ab56c 100644 >>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi >>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi >>> @@ -117,7 +117,7 @@ >>> emmc_pins: pinmux_emmc_pins { >>> pinctrl-single,pins = < >>> 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* >>> gpmc_csn1.mmc1_clk */ >>> - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* >>> gpmc_csn2.mmc1_cmd */ >>> + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* >>> gpmc_csn2.mmc1_cmd */ >>> 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* >>> gpmc_ad0.mmc1_dat0 */ >>> 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* >>> gpmc_ad1.mmc1_dat1 */ >>> 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* >>> gpmc_ad2.mmc1_dat2 */ >>> >> is'nt this a common change? why is it "black only"? if it is so, then >> the pinmux should probably be spun off outside bone-common.dtsi into >> boneblack.dtsi perhaps? >> > > It is applicable for add-on eMMC-cape for beagle bone white, so eMMC pinmux > can > remain in bone-common.dtsi. > However I could test only on beagle bone black which has eMMC on board, > since I > don't have access to eMMC-cape Could you update the patch to the effect please considering you are modifying am335x-bone-common.dtsi Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-24 2:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 17:38 [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd Balaji T K
[not found] ` <1379698696-21945-1-git-send-email-balajitk-l0cyMroinI0@public.gmane.org>
2013-09-20 17:44 ` Felipe Balbi
2013-09-20 19:11 ` Nishanth Menon
[not found] ` <523C9DE4.6040109-l0cyMroinI0@public.gmane.org>
2013-09-23 15:28 ` Balaji T K
[not found] ` <52405E30.2020001-l0cyMroinI0@public.gmane.org>
2013-09-24 2:24 ` Nishanth Menon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).