* [PATCH] spi: s3c64xx: Add missing compatibles
@ 2013-09-23 9:45 Mateusz Krawczuk
2013-09-23 13:50 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Mateusz Krawczuk @ 2013-09-23 9:45 UTC (permalink / raw)
To: broonie
Cc: kgene.kim, ben-linux, linux-arm-kernel, linux-samsung-soc,
linux-spi, linux-kernel, devicetree, Mateusz Krawczuk,
Kyungmin Park
Add compatibles for s3c6410, s5pc100 and s5pc110/s5pv210 boards.
Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/spi/spi-s3c64xx.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 8bed27a..84cc6ac 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1612,6 +1612,18 @@ static struct platform_device_id s3c64xx_spi_driver_ids[] = {
};
static const struct of_device_id s3c64xx_spi_dt_match[] = {
+ { .compatible = "samsung,s3c2443-spi",
+ .data = (void *)&s3c2443_spi_port_config,
+ },
+ { .compatible = "samsung,s3c6410-spi",
+ .data = (void *)&s3c6410_spi_port_config,
+ },
+ { .compatible = "samsung,s5pc100-spi",
+ .data = (void *)&s5pc100_spi_port_config,
+ },
+ { .compatible = "samsung,s5pv210-spi",
+ .data = (void *)&s5pv210_spi_port_config,
+ },
{ .compatible = "samsung,exynos4210-spi",
.data = (void *)&exynos4_spi_port_config,
},
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] spi: s3c64xx: Add missing compatibles
2013-09-23 9:45 [PATCH] spi: s3c64xx: Add missing compatibles Mateusz Krawczuk
@ 2013-09-23 13:50 ` Mark Brown
2013-09-23 14:03 ` Tomasz Figa
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2013-09-23 13:50 UTC (permalink / raw)
To: Mateusz Krawczuk
Cc: kgene.kim, ben-linux, linux-arm-kernel, linux-samsung-soc,
linux-spi, linux-kernel, devicetree, Kyungmin Park
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On Mon, Sep 23, 2013 at 11:45:45AM +0200, Mateusz Krawczuk wrote:
> Add compatibles for s3c6410, s5pc100 and s5pc110/s5pv210 boards.
> static const struct of_device_id s3c64xx_spi_dt_match[] = {
> + { .compatible = "samsung,s3c2443-spi",
> + .data = (void *)&s3c2443_spi_port_config,
> + },
> + { .compatible = "samsung,s3c6410-spi",
> + .data = (void *)&s3c6410_spi_port_config,
> + },
This is missing s3c6400 and at least one other s3c24xx I think. They
can be added later though so applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] spi: s3c64xx: Add missing compatibles
2013-09-23 13:50 ` Mark Brown
@ 2013-09-23 14:03 ` Tomasz Figa
0 siblings, 0 replies; 3+ messages in thread
From: Tomasz Figa @ 2013-09-23 14:03 UTC (permalink / raw)
To: Mark Brown
Cc: Mateusz Krawczuk, kgene.kim, ben-linux, linux-arm-kernel,
linux-samsung-soc, linux-spi, linux-kernel, devicetree,
Kyungmin Park
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
Hi Mark,
On Monday 23 of September 2013 14:50:42 Mark Brown wrote:
> On Mon, Sep 23, 2013 at 11:45:45AM +0200, Mateusz Krawczuk wrote:
> > Add compatibles for s3c6410, s5pc100 and s5pc110/s5pv210 boards.
>
> > static const struct of_device_id s3c64xx_spi_dt_match[] = {
> > + { .compatible = "samsung,s3c2443-spi",
> > + .data = (void *)&s3c2443_spi_port_config,
> > + },
> > + { .compatible = "samsung,s3c6410-spi",
> > + .data = (void *)&s3c6410_spi_port_config,
> > + },
>
> This is missing s3c6400 and at least one other s3c24xx I think. They
> can be added later though so applied, thanks.
I think after this patch the table lists all the SoC variants supported
by the driver, at least it's what I can tell from a quick look at
s3c64xx_spi_driver_ids[] array.
The compatible for S3C64xx should be probably called "samsung,s3c6400",
though, as it's the first SoC with this variant.
Best regards,
Tomasz
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-23 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 9:45 [PATCH] spi: s3c64xx: Add missing compatibles Mateusz Krawczuk
2013-09-23 13:50 ` Mark Brown
2013-09-23 14:03 ` Tomasz Figa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).