From: Simon Horman <horms@verge.net.au>
To: takasi-y@ops.dti.ne.jp
Cc: SH-Linux <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
ben.dooks@codethink.co.uk,
Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>,
devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>,
Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/6] serial8250-em: convert to clk_prepare/unprepare
Date: Tue, 24 Sep 2013 13:44:32 +0900 [thread overview]
Message-ID: <20130924044432.GD3619@verge.net.au> (raw)
In-Reply-To: <20130924131039.3c871cad7acb2a068a988d0f@ops.dti.ne.jp>
[ CCed Greg Kroah-Hartman, the serial maintainer for his review ]
On Tue, Sep 24, 2013 at 01:10:39PM +0900, takasi-y@ops.dti.ne.jp wrote:
> From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
>
> Add calls to clk_prepare and unprepare so that EMMA Mobile EV2 can
> migrate to the common clock framework.
>
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> [takashi.yoshii.ze@renesas.com: edited for conflicts]
> Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@renesas.com>
> ---
> drivers/tty/serial/8250/8250_em.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_em.c b/drivers/tty/serial/8250/8250_em.c
> index 5f3bba1..d1a9078 100644
> --- a/drivers/tty/serial/8250/8250_em.c
> +++ b/drivers/tty/serial/8250/8250_em.c
> @@ -122,7 +122,7 @@ static int serial8250_em_probe(struct platform_device *pdev)
> up.port.dev = &pdev->dev;
> up.port.private_data = priv;
>
> - clk_enable(priv->sclk);
> + clk_prepare_enable(priv->sclk);
> up.port.uartclk = clk_get_rate(priv->sclk);
>
> up.port.iotype = UPIO_MEM32;
> @@ -134,7 +134,7 @@ static int serial8250_em_probe(struct platform_device *pdev)
> ret = serial8250_register_8250_port(&up);
> if (ret < 0) {
> dev_err(&pdev->dev, "unable to register 8250 port\n");
> - clk_disable(priv->sclk);
> + clk_disable_unprepare(priv->sclk);
> return ret;
> }
>
> @@ -148,7 +148,7 @@ static int serial8250_em_remove(struct platform_device *pdev)
> struct serial8250_em_priv *priv = platform_get_drvdata(pdev);
>
> serial8250_unregister_port(priv->line);
> - clk_disable(priv->sclk);
> + clk_disable_unprepare(priv->sclk);
> return 0;
> }
>
> --
> 1.8.1.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-09-24 4:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 4:05 [PATCH 0/6] ARM: shmobile: kzm9d-reference: migrate to common clock framework with DT Takashi Yoshii
2013-09-24 4:09 ` [PATCH 1/6] clocksource: em_sti: convert to clk_prepare/unprepare takasi-y
2013-09-24 4:42 ` Simon Horman
2013-09-26 10:18 ` Daniel Lezcano
[not found] ` <20130924130924.61d4ecedf3d4fca5952d55fc-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-09-30 15:25 ` Laurent Pinchart
[not found] ` <52440A07.4050101-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-10-03 2:30 ` Simon Horman
2013-10-01 9:05 ` Magnus Damm
2013-09-24 4:10 ` [PATCH 2/6] serial8250-em: " takasi-y
2013-09-24 4:44 ` Simon Horman [this message]
2013-09-24 13:41 ` Greg Kroah-Hartman
2013-09-30 15:25 ` Laurent Pinchart
[not found] ` <20130924134113.GA7246-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-10-03 2:30 ` Simon Horman
[not found] ` <20130924131039.3c871cad7acb2a068a988d0f-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-10-01 9:07 ` Magnus Damm
2013-09-24 4:12 ` [PATCH 3/6] sh: clkfwk: Select sh-/common- clkfwk alternatively takasi-y
2013-09-30 18:40 ` Laurent Pinchart
2013-10-04 5:25 ` takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-10-01 9:30 ` Magnus Damm
2013-09-24 4:13 ` [PATCH 4/6] ARM: shmobile: emev2: Define SMU clock DT bindings takasi-y
[not found] ` <20130924131331.0e9a5f830f531655b2ea0ebe-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-09-24 4:52 ` Simon Horman
2013-09-24 9:00 ` takashi.yoshii.zj
[not found] ` <20130924045215.GE3619-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-10-01 11:36 ` Laurent Pinchart
2013-10-02 1:28 ` Simon Horman
2013-10-06 17:16 ` Takashi YOSHII
[not found] ` <52410F86.4040301-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2013-09-24 4:15 ` [PATCH 5/6] clk: emev2: Add support for emev2 SMU clocks with DT takasi-y-nDL5PR/MsHhHfZP73Gtkiw
[not found] ` <20130924131542.f865fad4dec98e024c0d4676-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-10-01 9:15 ` Magnus Damm
2013-10-01 12:27 ` Laurent Pinchart
[not found] ` <CANqRtoRD35Ei31PK8a_TOp=2uiYPCoaJuDb6tyZtQL8s0PavNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-04 5:44 ` takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-09-24 4:17 ` [PATCH 6/6] ARM: shmobile: kzm9d-reference: Use common clock framework takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-09-24 4:55 ` Simon Horman
2013-10-01 9:23 ` Magnus Damm
2013-09-25 7:17 ` [PATCH 0/6] ARM: shmobile: kzm9d-reference: migrate to common clock framework with DT Kuninori Morimoto
[not found] ` <87siwtl69z.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2013-10-04 1:12 ` takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-09-24 4:56 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924044432.GD3619@verge.net.au \
--to=horms@verge.net.au \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@linaro.org \
--cc=shinya.kuribayashi.px@renesas.com \
--cc=takasi-y@ops.dti.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).