From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [RFC v2] gpio/omap: auto-setup a GPIO when used as an IRQ Date: Tue, 24 Sep 2013 08:58:08 -0700 Message-ID: <20130924155808.GP2684@atomide.com> References: <1380009480-4975-1-git-send-email-javier.martinez@collabora.co.uk> <20130924154048.GM2684@atomide.com> <5241B3B7.5070701@ti.com> <5241B465.5050604@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5241B465.5050604-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Santosh Shilimkar Cc: Balaji T K , Javier Martinez Canillas , Kevin Hilman , Linus Walleij , Stephen Warren , Lars Poeschel , Grant Likely , Mark Rutland , Ian Campbell , Kumar Gala , Pawel Moll , Tomasz Figa , Enric Balletbo i Serra , Jean-Christophe PLAGNIOL-VILLARD , Jon Hunter , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, r.sricharan-l0cyMroinI0@public.gmane.org, holler-SXC+2es9fhnfWeYVQQPykw@public.gmane.org List-Id: devicetree@vger.kernel.org * Santosh Shilimkar [130924 08:56]: > On Tuesday 24 September 2013 11:45 AM, Balaji T K wrote: > > On Tuesday 24 September 2013 09:10 PM, Tony Lindgren wrote: > >> * Javier Martinez Canillas [130924 01:06]: > >>> The OMAP GPIO controller HW requires a pin to be configured in GPIO > >>> input mode in order to operate as an interrupt input. Since drivers > >>> should not be aware of whether an interrupt pin is also a GPIO or not, > >>> the HW should be fully configured/enabled as an IRQ if a driver solely > >>> uses IRQ APIs such as request_irq(), and never calls any GPIO-related > >>> APIs. As such, add the missing HW setup to the OMAP GPIO controller's > >>> irq_chip driver. > >>> > >>> Since this bypasses the GPIO subsystem we have to ensure that another > >>> caller won't be able to request the same GPIO pin that is used as an > >>> IRQ and set its direction as output. Requesting the GPIO and setting > >>> its direction as input is allowed though. > >> > >> Also please mention the regression that this fixes. So far we know > >> that smsc911x for tobi and igep boards in mainline, and also the > > > >> MMC card detect for omap4 boards. > > Hi Tony, > > > > Card detect on omap4 board (sdp and panda) is not based on omap gpio, > > so I think this fix is not applicable for omap4. > > > > Card detect line for SD card goes to power IC on OMAP4 panda and SDP. > > > I confused Tony mostly. It was OMAP4 SPI based ethernet which uses the > GPIO as an interrupt line. > > So for Panda, its Ethernet driver and not MMC. OK :) Thanks for clarifying. Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html