Re: device tree binding documentation outdated

[Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

On Fri, Sep 27, 2013 at 10:49:02AM +0100, Russell King - ARM Linux wrote:
> Here's another instance:
> 
> Documentation/devicetree/bindings/net/fsl-fec.txt:
> 
> Required properties:
> - phy-mode : String, operation mode of the PHY interface.
>   Supported values are: "mii", "gmii", "sgmii", "tbi", "rmii",
>   "rgmii", "rgmii-id", "rgmii-rxid", "rgmii-txid", "rtbi", "smii".
> 
> Is this really required?  Maybe someone can point to where the code
> makes use of this, because I'm damned if I can find it:
> 
> $ grep phy-mode drivers/net/ include/ net/ -r
> drivers/net/ethernet/marvell/mvneta.c:              dev_err(&pdev->dev, "incorrect phy-mode\n");
> drivers/net/ethernet/nxp/lpc_eth.c:                                            phy-mode", NULL);

See of_get_phy_mode() implemented in drivers/net/of_net.c and used in
the FEC driver.

> 
> "local-mac-address" in the optional properties also falls into this
> category: only a small handful of network drivers make use of this,
> and fec is not one of them.

of_get_mac_address(), also in drivers/net/of_net.c

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html