From: Nishanth Menon <nm@ti.com>
To: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: swarren@wwwdotorg.org, pawel.moll@arm.com, mark.rutland@arm.com,
ian.campbell@citrix.com, rob.herring@calxeda.com,
linux@roeck-us.net, rui.zhang@intel.com, grant.likely@linaro.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] arm: dts: add tmp102 i2c sensor node on dra7-evm
Date: Tue, 1 Oct 2013 17:51:08 -0500 [thread overview]
Message-ID: <20131001225108.GA11885@kahuna> (raw)
In-Reply-To: <1380652344-18819-7-git-send-email-eduardo.valentin@ti.com>
On 14:32-20131001, Eduardo Valentin wrote:
> On dra7-evm there is an tmp102 temperature sensor on i2c bus 1.
> This patch adds its device tree node.
>
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> arch/arm/boot/dts/dra7-evm.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
> index 21fe16b..3b6c16a 100644
> --- a/arch/arm/boot/dts/dra7-evm.dts
> +++ b/arch/arm/boot/dts/dra7-evm.dts
> @@ -7,6 +7,8 @@
> */
> /dts-v1/;
>
> +#include <dt-bindings/thermal/thermal.h>
> +
^^ needed?
> #include "dra7.dtsi"
>
> / {
> @@ -93,6 +95,12 @@
> pinctrl-names = "default";
> pinctrl-0 = <&i2c1_pins>;
> clock-frequency = <400000>;
could you add an EOL here?
> + tmp102: tmp102@48{
a space before the {?
> + compatible = "ti,tmp102";
> + reg = <0x48>;
> +
> + #thermal-sensor-cells = <0>;
> + };
> };
>
> &i2c2 {
> --
> 1.8.2.1.342.gfa7285d
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-10-01 22:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 18:32 [PATCH 0/7] DRA7: DT thermal support Eduardo Valentin
2013-10-01 18:32 ` [PATCH 1/7] arm: dts: add dra7 DSPEVE thermal data Eduardo Valentin
2013-10-01 22:37 ` Nishanth Menon
2013-10-02 1:27 ` Eduardo Valentin
[not found] ` <1380652344-18819-1-git-send-email-eduardo.valentin-l0cyMroinI0@public.gmane.org>
2013-10-01 18:32 ` [PATCH 2/7] arm: dts: add dra7 IVA " Eduardo Valentin
2013-10-01 22:33 ` Nishanth Menon
2013-10-02 1:26 ` Eduardo Valentin
2013-10-01 22:58 ` [PATCH 0/7] DRA7: DT thermal support Nishanth Menon
2013-10-02 1:45 ` Eduardo Valentin
2013-10-01 18:32 ` [PATCH 3/7] arm: dts: dra7: add bandgap entry Eduardo Valentin
[not found] ` <1380652344-18819-4-git-send-email-eduardo.valentin-l0cyMroinI0@public.gmane.org>
2013-10-01 22:46 ` Nishanth Menon
2013-10-02 1:28 ` Eduardo Valentin
2013-11-06 20:23 ` [PATCHv2 " Eduardo Valentin
2013-10-01 18:32 ` [PATCH 4/7] arm: dts: add cooling properties on dra7 cpu node Eduardo Valentin
2013-10-01 18:32 ` [PATCH 5/7] arm: dts: dra7: add thermal data Eduardo Valentin
2013-10-01 18:32 ` [PATCH 6/7] arm: dts: add tmp102 i2c sensor node on dra7-evm Eduardo Valentin
2013-10-01 22:51 ` Nishanth Menon [this message]
2013-10-02 1:32 ` Eduardo Valentin
2013-10-01 18:32 ` [PATCH 7/7] arm: dts: add thermal zones info on tmp102 for DRA7-EVM Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001225108.GA11885@kahuna \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=eduardo.valentin@ti.com \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rui.zhang@intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).