From: Nishanth Menon <nm@ti.com>
To: Joel Fernandes <joelf@ti.com>
Cc: Kevin Hilman <khilman@linaro.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>, Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org,
Kevin Hilman <khilman@deeprootsystems.com>,
Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init
Date: Thu, 10 Oct 2013 08:32:10 -0500 [thread overview]
Message-ID: <20131010133209.GA13105@kahuna> (raw)
In-Reply-To: <52563BD8.1060703@ti.com>
On 00:32-20131010, Joel Fernandes wrote:
> On 10/09/2013 06:24 PM, Nishanth Menon wrote:
> > Call OMAP2+ generic lateinit hook from AM specific late init hook.
> > This allows the generic late initializations such as cpufreq hooks
> > to be active.
> >
> > Cc: Benoit Cousson <bcousson@baylibre.com>
> > Cc: Kevin Hilman <khilman@deeprootsystems.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> > arch/arm/mach-omap2/board-generic.c | 1 +
> > arch/arm/mach-omap2/common.h | 1 +
> > arch/arm/mach-omap2/io.c | 6 ++++++
> > 3 files changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> > index 87162e1..b474498 100644
> > --- a/arch/arm/mach-omap2/board-generic.c
> > +++ b/arch/arm/mach-omap2/board-generic.c
> > @@ -180,6 +180,7 @@ DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)")
> > .init_irq = omap_intc_of_init,
> > .handle_irq = omap3_intc_handle_irq,
> > .init_machine = omap_generic_init,
> > + .init_late = am33xx_init_late,
>
> Instead of adding a new a *_init_late function for every platform, perhaps
> better to just do:
> .init_late = omap2_common_pm_late_init;
>
> since that's the only function you're calling.
>
> Later if more functions are added, then it can be wrapped around.
And what benefit would that give us? we break consistency of functions
available in io.c, considering the work we have already done in
out-of-tree patches on ti-forks, we *do know* that there is more
incoming and has to be done anyways, I prefer having symmetric
functions and a placeholder that folks can add on to.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-10-10 13:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 21:28 [PATCH V6 00/15] ARM: OMAP3+: support cpufreq-cpu0 for device tree boot Nishanth Menon
2013-10-09 21:28 ` [PATCH V6 01/15] ARM: OMAP3+: do not register non-dt OPP tables " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 03/15] ARM: OMAP2+: AM43XX: " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 04/15] ARM: OMAP2+: OMAP5: " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 05/15] ARM: OMAP2+: DRA7: " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 06/15] ARM: OMAP3+: use cpu0-cpufreq driver in device tree supported boot Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 07/15] ARM: dts: omap5-uevm: add smps123 supply for CPU Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 08/15] ARM: dts: dra7-evm: " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 09/15] ARM: dts: OMAP5: Add CPU OPP table Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 10/15] ARM: dts: DRA7: " Nishanth Menon
2013-10-10 5:32 ` [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init Joel Fernandes
2013-10-10 13:32 ` Nishanth Menon [this message]
2013-10-10 15:20 ` Joel Fernandes
2013-10-10 15:23 ` Joel Fernandes
2013-10-10 15:45 ` Nishanth Menon
2013-10-10 15:53 ` Joel Fernandes
2013-10-11 16:11 ` Tony Lindgren
2013-10-10 13:33 ` Vaibhav Bedia
2013-10-09 23:30 ` Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 03/15] ARM: OMAP2+: AM43XX: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 04/15] ARM: OMAP2+: OMAP5: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 05/15] ARM: OMAP2+: DRA7: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 06/15] ARM: OMAP3+: use cpu0-cpufreq driver in device tree supported boot Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 07/15] ARM: dts: omap5-uevm: add smps123 supply for CPU Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 08/15] ARM: dts: dra7-evm: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 09/15] ARM: dts: OMAP5: Add CPU OPP table Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 11/15] ARM: dts: OMAP3: add clock nodes for CPU Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 12/15] ARM: dts: OMAP4: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 13/15] ARM: dts: AM33XX: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 14/15] ARM: dts: OMAP5: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 15/15] ARM: dts: DRA7: " Nishanth Menon
2013-10-09 23:31 ` [PATCH V6 00/15] ARM: OMAP3+: support cpufreq-cpu0 for device tree boot Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010133209.GA13105@kahuna \
--to=nm@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=joelf@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).