devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: devicetree@vger.kernel.org,
	"Grygorii Strashko" <grygorii.strashko@ti.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org,
	"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
	"Prakash Manjunathappa" <prakash.pm@ti.com>,
	"Haojian Zhuang" <haojian.zhuang@linaro.org>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts
Date: Thu, 10 Oct 2013 09:23:15 -0700	[thread overview]
Message-ID: <20131010162314.GD29913@atomide.com> (raw)
In-Reply-To: <20131010160018.GA29913@atomide.com>

* Tony Lindgren <tony@atomide.com> [131010 09:09]:
> * Roger Quadros <rogerq@ti.com> [131010 06:32]:
> > 
> > I tried testing this with the USB EHCI driver, but I'm not getting wake up interrupts
> > while the system is still running and only the EHCI controller is runtime suspended.
> > 
> > It seems we need to somehow call _reconfigure_io_chain() to update the daisy chain
> > whenever the pad wakeup_enable bit is changed.
> 
> Sounds like this is on omap3? Have you tried calling pcs_soc->rearm() in the
> pcs_irq_handle() like the comments there suggest? At least for me that keeps
> the wake-up interrupts continuously running on omap3 instead of just idle modes.
> 
> Now on omap4, I've noticed the wake up interrupts are on all the time based on tests
> with the serial driver.

Oh, and if you're runtime suspending EHCI only, and if the EHCI module has
wake-up registers, it should be able to wake EHCI from retention on it's own
without a need for the io chain at all.

At least the serial driver does that if it's internal wake-up registers are
configured right. But for off-idle, the serial driver needs the io chain wake-up
events.

Regards,

Tony

  parent reply	other threads:[~2013-10-10 16:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20131003054104.8941.88857.stgit@localhost>
2013-10-03  5:42 ` [PATCH 1/6] ARM: dts: Fix pinctrl mask for omap3 Tony Lindgren
2013-10-03  5:42 ` [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts Tony Lindgren
2013-10-03 17:50   ` Tony Lindgren
2013-10-08 12:10   ` Linus Walleij
2013-10-08 16:05     ` Tony Lindgren
2013-10-10 13:24   ` Roger Quadros
     [not found]     ` <5256AA7F.8030005-l0cyMroinI0@public.gmane.org>
2013-10-10 14:04       ` Linus Walleij
     [not found]         ` <CACRpkdZx5+OCcQytkpjd7_nz4hw6VXoXOS0LByKgJ8_cQjbA4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-10 14:35           ` Roger Quadros
2013-10-10 15:32             ` Linus Walleij
     [not found]               ` <CACRpkdY6NSR7gSc6=_nEr_BdTiEM0Mt9t4GoBSoP26ceVphDhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-10 16:15                 ` Tony Lindgren
2013-10-10 16:00     ` Tony Lindgren
2013-10-10 16:11       ` Linus Walleij
2013-10-10 16:20         ` Tony Lindgren
2013-10-11  8:00           ` Linus Walleij
2013-10-11  8:56             ` Roger Quadros
2013-10-11 10:32               ` Linus Walleij
2013-10-11 15:43                 ` Tony Lindgren
2013-10-11 15:56                   ` Linus Walleij
2013-10-11 16:01                     ` Tony Lindgren
2013-10-18  7:40                       ` Balaji T K
2013-10-18 15:35                         ` Tony Lindgren
2013-10-18 15:59                           ` Balaji T K
     [not found]                             ` <52615AD4.7040306-l0cyMroinI0@public.gmane.org>
2013-10-18 16:06                               ` Tony Lindgren
2013-10-11 15:36               ` Tony Lindgren
2013-10-11 15:43                 ` Balaji T K
2013-10-11 15:48                   ` Tony Lindgren
2013-10-10 16:23       ` Tony Lindgren [this message]
2013-10-11  8:45         ` Roger Quadros
2013-10-11  8:49       ` Roger Quadros
     [not found]         ` <5257BB8C.5080001-l0cyMroinI0@public.gmane.org>
2013-10-11 13:59           ` Roger Quadros
     [not found]             ` <52580438.4040002-l0cyMroinI0@public.gmane.org>
2013-10-11 15:18               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010162314.GD29913@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=haojian.zhuang@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=prakash.pm@ti.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).