From: Tony Lindgren <tony@atomide.com>
To: Joel Fernandes <joelf@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Kevin Hilman <khilman@linaro.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org,
Kevin Hilman <khilman@deeprootsystems.com>,
Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init
Date: Fri, 11 Oct 2013 09:11:17 -0700 [thread overview]
Message-ID: <20131011161116.GS29913@atomide.com> (raw)
In-Reply-To: <5256C686.6000301@ti.com>
* Joel Fernandes <joelf@ti.com> [131010 08:31]:
> On 10/10/2013 10:20 AM, Joel Fernandes wrote:
> >
> > Adding 6 lines of identical code for every platform seems redundant, I'd just
> > define an omap_common_late_init for all platforms for now, and then fork off for
> > the future differences. That way we save on LOC and readability in the header as
> > well. Your call.
>
> I see a function of that name already exists. I guess you can leave your patch
> as is then and not have to do this.
Yeah but why not just call the common late_init function directly for the
cases where we know it's never needed.
If thoses will be populated in the later patches, then it's OK to add them.
In any case, Nishant, can you please squash the late_init patches into a
single patch and make sure it also applies on top of the omap-for-v3.13/quirk
branch as there's been some changes to board-generic.c there.
Regards,
Tony
next prev parent reply other threads:[~2013-10-11 16:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 21:28 [PATCH V6 00/15] ARM: OMAP3+: support cpufreq-cpu0 for device tree boot Nishanth Menon
2013-10-09 21:28 ` [PATCH V6 01/15] ARM: OMAP3+: do not register non-dt OPP tables " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 03/15] ARM: OMAP2+: AM43XX: " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 04/15] ARM: OMAP2+: OMAP5: " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 05/15] ARM: OMAP2+: DRA7: " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 06/15] ARM: OMAP3+: use cpu0-cpufreq driver in device tree supported boot Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 07/15] ARM: dts: omap5-uevm: add smps123 supply for CPU Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 08/15] ARM: dts: dra7-evm: " Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 09/15] ARM: dts: OMAP5: Add CPU OPP table Nishanth Menon
2013-10-09 23:24 ` [PATCH V6 10/15] ARM: dts: DRA7: " Nishanth Menon
2013-10-10 5:32 ` [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init Joel Fernandes
2013-10-10 13:32 ` Nishanth Menon
2013-10-10 15:20 ` Joel Fernandes
2013-10-10 15:23 ` Joel Fernandes
2013-10-10 15:45 ` Nishanth Menon
2013-10-10 15:53 ` Joel Fernandes
2013-10-11 16:11 ` Tony Lindgren [this message]
2013-10-10 13:33 ` Vaibhav Bedia
2013-10-09 23:30 ` Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 03/15] ARM: OMAP2+: AM43XX: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 04/15] ARM: OMAP2+: OMAP5: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 05/15] ARM: OMAP2+: DRA7: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 06/15] ARM: OMAP3+: use cpu0-cpufreq driver in device tree supported boot Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 07/15] ARM: dts: omap5-uevm: add smps123 supply for CPU Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 08/15] ARM: dts: dra7-evm: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 09/15] ARM: dts: OMAP5: Add CPU OPP table Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 11/15] ARM: dts: OMAP3: add clock nodes for CPU Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 12/15] ARM: dts: OMAP4: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 13/15] ARM: dts: AM33XX: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 14/15] ARM: dts: OMAP5: " Nishanth Menon
2013-10-09 23:30 ` [PATCH V6 15/15] ARM: dts: DRA7: " Nishanth Menon
2013-10-09 23:31 ` [PATCH V6 00/15] ARM: OMAP3+: support cpufreq-cpu0 for device tree boot Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011161116.GS29913@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=joelf@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).