From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH] ARM: mvebu: dts: remove unneeded linux,default-state from led nodes
Date: Mon, 14 Oct 2013 20:28:21 +0200 [thread overview]
Message-ID: <20131014182821.GD25095@lunn.ch> (raw)
In-Reply-To: <1381774047-23354-1-git-send-email-jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
On Mon, Oct 14, 2013 at 06:07:27PM +0000, Jason Cooper wrote:
> Generally, power LEDs should indicate when power is applied, and go out
> once power is removed. _Not_ annoy the developer with migraine-inducing
> blinking reminicent of some badly animated television series designed to
> sell sugar to children.
>
> On a more serious note, most of these OS-specific properties aren't
> necessary and should be removed. I left two that are legitimately tying
> disk LEDs to disk activity. Other than that, we keep the state the
> bootloader left them in until userspace changes the state via sysfs.
Hi Jason
Do you know what happens with "keep" and the bootloader setting the
LED to hardware blink? I'm just wondering if some of these default-on,
are actually disabling hardware blinking and making it constant on?
Thanks
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-14 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 18:07 [PATCH] ARM: mvebu: dts: remove unneeded linux,default-state from led nodes Jason Cooper
[not found] ` <1381774047-23354-1-git-send-email-jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
2013-10-14 18:28 ` Andrew Lunn [this message]
[not found] ` <20131014182821.GD25095-g2DYL2Zd6BY@public.gmane.org>
2013-10-14 18:36 ` Jason Cooper
[not found] ` <20131014183633.GK5402-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2013-10-28 15:17 ` Simon Baatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014182821.GD25095@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).