From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] ARM: mvebu: dts: remove unneeded linux,default-state from led nodes Date: Mon, 14 Oct 2013 20:28:21 +0200 Message-ID: <20131014182821.GD25095@lunn.ch> References: <1381774047-23354-1-git-send-email-jason@lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1381774047-23354-1-git-send-email-jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Cooper Cc: Andrew Lunn , Gregory CLEMENT , Sebastian Hesselbarth , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Petazzoni , Ezequiel Garcia List-Id: devicetree@vger.kernel.org On Mon, Oct 14, 2013 at 06:07:27PM +0000, Jason Cooper wrote: > Generally, power LEDs should indicate when power is applied, and go out > once power is removed. _Not_ annoy the developer with migraine-inducing > blinking reminicent of some badly animated television series designed to > sell sugar to children. > > On a more serious note, most of these OS-specific properties aren't > necessary and should be removed. I left two that are legitimately tying > disk LEDs to disk activity. Other than that, we keep the state the > bootloader left them in until userspace changes the state via sysfs. Hi Jason Do you know what happens with "keep" and the bootloader setting the LED to hardware blink? I'm just wondering if some of these default-on, are actually disabling hardware blinking and making it constant on? Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html