From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Subject: [PATCH v2 3/5] pinctrl: rockchip: remove redundant check
Date: Wed, 16 Oct 2013 01:08:11 +0200 [thread overview]
Message-ID: <201310160108.12261.heiko@sntech.de> (raw)
In-Reply-To: <201310160106.42329.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
The check limiting bias options to supported ones is already
done thru rockchip_pinconf_pull_valid. Therefore this check is
redundant and can be removed.
Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
---
drivers/pinctrl/pinctrl-rockchip.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index efca116..91027dd 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -424,12 +424,6 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank,
switch (ctrl->type) {
case RK2928:
- if (pull != PIN_CONFIG_BIAS_PULL_PIN_DEFAULT &&
- pull != PIN_CONFIG_BIAS_DISABLE) {
- dev_err(info->dev, "only PIN_DEFAULT and DISABLE allowed\n");
- return -EINVAL;
- }
-
ctrl->pull_calc_reg(bank, pin_num, ®, &bit);
spin_lock_irqsave(&bank->slock, flags);
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-15 23:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 23:06 [PATCH v2 0/5] pinctrl: rockchip: add rk3188 support Heiko Stübner
[not found] ` <201310160106.42329.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-10-15 23:07 ` [PATCH v2 1/5] pinctrl: rockchip: separate different sub-types more Heiko Stübner
[not found] ` <201310160107.21147.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-10-16 11:40 ` Linus Walleij
2013-10-15 23:07 ` [PATCH v2 2/5] pinctrl: rockchip: add support for multiple bank types Heiko Stübner
[not found] ` <201310160107.50032.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-10-16 11:41 ` Linus Walleij
2013-10-15 23:08 ` Heiko Stübner [this message]
[not found] ` <201310160108.12261.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-10-16 11:42 ` [PATCH v2 3/5] pinctrl: rockchip: remove redundant check Linus Walleij
2013-10-15 23:08 ` [PATCH v2 4/5] pinctrl: rockchip: add rk3188 specifics Heiko Stübner
[not found] ` <201310160108.43199.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-10-16 11:46 ` Linus Walleij
2013-10-15 23:09 ` [PATCH v2 5/5] pinctrl: rockchip: emulate both edge triggered interrupts Heiko Stübner
[not found] ` <201310160109.08771.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-10-16 11:47 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310160108.12261.heiko@sntech.de \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).