From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 4/5] ARM: ux500: fix I2C4 clock bit Date: Fri, 18 Oct 2013 12:03:14 +0100 Message-ID: <20131018110314.GV19112@lee--X1> References: <1382087123-31702-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1382087123-31702-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 18 Oct 2013, Linus Walleij wrote: > The PCLK for I2C4 is controlled by bit 10 in the PCKEN registers > while the KCLK is controlled by bit 9 on the KCKEN, it's > one of these odd assymetric things. Correct the PCLK bit to 10. >=20 > Cc: Lee Jones > Signed-off-by: Linus Walleij > --- > arch/arm/boot/dts/ste-dbx5x0.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/st= e-dbx5x0.dtsi > index 5112f4c..b7d1738 100644 > --- a/arch/arm/boot/dts/ste-dbx5x0.dtsi > +++ b/arch/arm/boot/dts/ste-dbx5x0.dtsi > @@ -694,7 +694,7 @@ > =20 > clock-frequency =3D <400000>; > =20 > - clocks =3D <&prcc_kclk 1 9>, <&prcc_pclk 1 9>; > + clocks =3D <&prcc_kclk 1 10>, <&prcc_pclk 1 9>; > clock-names =3D "i2cclk", "apb_pclk"; > }; > =20 NACK: Bit 10 is MSP1 clk =3D clk_reg_prcc_kclk("p1_i2c4_kclk", "i2cclk", clkrst1_base, BIT(9), CLK_SET_RATE_GATE); clk_register_clkdev(clk, NULL, "nmk-i2c.4"); PRCC_KCLK_STORE(clk, 1, 9); =20 clk =3D clk_reg_prcc_kclk("p1_msp3_kclk", "msp1clk", clkrst1_base, BIT(10), CLK_SET_RATE_GATE); clk_register_clkdev(clk, NULL, "msp3"); clk_register_clkdev(clk, NULL, "ux500-msp-i2s.3"); PRCC_KCLK_STORE(clk, 1, 10); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html