From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/5] clk: ux500: fix erroneous bit assignment Date: Fri, 18 Oct 2013 12:06:50 +0100 Message-ID: <20131018110650.GX19112@lee--X1> References: <1382087097-31627-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1382087097-31627-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mike Turquette , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 18 Oct 2013, Linus Walleij wrote: > Due to a typo or similar, the peripheral group 2 clock 11 > gate was set to bit 1 instead of bit 11. We need to fix this > to be able to set the correct enable bit in the device tree: > when trying to correct the bit assignment in the device tree, > the system would hang. >=20 > Cc: Lee Jones > Cc: Mike Turquette > Signed-off-by: Linus Walleij > --- > Mike: seeking an ACK for this as it needs to be taken into > ARM SoC with the rest of the fixes so as not to cause > bisection problems between the trees. > --- > drivers/clk/ux500/u8500_of_clk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u85= 00_of_clk.c > index b768b50..cdeff29 100644 > --- a/drivers/clk/ux500/u8500_of_clk.c > +++ b/drivers/clk/ux500/u8500_of_clk.c > @@ -339,7 +339,7 @@ void u8500_of_clk_init(u32 clkrst1_base, u32 clkr= st2_base, u32 clkrst3_base, > =20 > clk =3D clk_reg_prcc_pclk("p2_pclk11", "per2clk", clkrst2_base, > BIT(11), 0); > - PRCC_PCLK_STORE(clk, 2, 1); > + PRCC_PCLK_STORE(clk, 2, 11); Ah, you found it already. Nice. Acked-by: Lee Jones --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html