Re: [RFC v2 PATCH 13/14] Documentation: Add st_pressure binding documentation

[Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>]

On Fri, Sep 27, 2013 at 05:32:17PM +0100, Lukasz Czerwinski wrote:
> This patch adds the document for STMicroeletronics Pressure Sensors
> driver under Documentation/devicetree/bindings/iio/.
> 
> Signed-off-by: Lukasz Czerwinski <l.czerwinski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  .../bindings/iio/barometer/st_barometer.txt        |   38 ++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/barometer/st_barometer.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/barometer/st_barometer.txt b/Documentation/devicetree/bindings/iio/barometer/st_barometer.txt
> new file mode 100644
> index 0000000..5ce4bfa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/barometer/st_barometer.txt
> @@ -0,0 +1,38 @@
> +STMicroelectronics Pressure Sensors
> +
> +Required properties:
> +
> +  - compatible : value should be:
> +	(a) "st,lps331ap" for barometer in LPS331AP

When you say "for the barometer in LPS331AP", is the LPS331AP a multi function
device? Or only a barometer?

> +	(b) "st,lps001wp" for barometer in LPS001WP
> +
> +  - reg : the I2C address of the barometer
> +
> +Optional properties:
> +
> +  - st,drdy-int-pin : redirect DRDY on pin INT1 (1) or pin INT2 (2) (u8)
> +
> +  - interrupts : Interrupt numbers for the ST barometer, as an array
> +	in case the barometer have more interrupt lines:
> +	<DataReady irq>,
> +	<Event irq>;
> +
> +  - interrupt-names : Array of strings associated with the interrupt numbers

The comments from patch 11 apply here too.

> +
> +  - vdd-supply: Phandle to the Vdd supply regulator
> +
> +  - vddio-supply: Phandle to the Vdd-IO supply regulator

These seem fine.

Thanks,
Mark.