From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [RESEND PATCHv2] watchdog: dw: Enable OF support for DW watchdog timer. Date: Tue, 22 Oct 2013 11:39:40 +0100 Message-ID: <20131022103936.GA5511@kartoffel> References: <1380739472-26172-1-git-send-email-dinguyen@altera.com> <20131021110532.GA8144@kartoffel> <5265C9B0.2060003@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <5265C9B0.2060003-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guenter Roeck Cc: "dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org" , "dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , Jamie Iles , Viresh Kumar , Wim Van Sebroeck , Pavel Machek , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , Pawel Moll , Stephen Warren , Ian Campbell , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Oct 22, 2013 at 01:41:20AM +0100, Guenter Roeck wrote: > On 10/21/2013 04:05 AM, Mark Rutland wrote: > > On Wed, Oct 02, 2013 at 07:44:32PM +0100, dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org wrote: > >> From: Dinh Nguyen > >> > >> Add device tree support to the DW watchdog timer. > >> > >> Signed-off-by: Dinh Nguyen > >> Acked-by: Jamie Iles > >> Reviewed-by: Pavel Machek > >> Cc: Guenter Roeck > >> Cc: Jamie Iles > >> Cc: Viresh Kumar > >> Cc: Wim Van Sebroeck > >> Cc: Pavel Machek > >> Cc: Rob Herring > >> Cc: Pawel Moll > >> Cc: Mark Rutland > >> Cc: Stephen Warren > >> Cc: Ian Campbell > >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >> Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >> --- > >> v2: > >> - Use of_match_ptr() for of_match_table > >> --- > >> .../devicetree/bindings/watchdog/dw_wdt.txt | 16 ++++++++++++++++ > >> drivers/watchdog/dw_wdt.c | 8 ++++++++ > >> 2 files changed, 24 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/watchdog/dw_wdt.txt > >> > >> diff --git a/Documentation/devicetree/bindings/watchdog/dw_wdt.txt b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt > >> new file mode 100644 > >> index 0000000..29e150b > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt > >> @@ -0,0 +1,16 @@ > >> +Synopsys Designware Watchdog Timer > >> + > >> +Required Properties: > >> + > >> +- Compatiblity : "snps,dw-wdt" > > > > This should presumably be: > > > > - compatbile: should contain "snps,dw-wdt" > > > > Hi Mark, > > s/compatbile/compatible/ :-) Indeed :) > > "must be" or "should contain" ? I see both in various bindings. > Is there a preference ? I would prefer "should contain" -- it doesn't preclude future compatible variants. > > >> +- reg : Base address of the watchdog timer register. > > > > And the size... > > > >> + > >> +Example: > >> + > >> + watchdog0: wd@ffd02000 { > >> + compatible = "snps,dw-wdt"; > >> + reg = <0xffd02000 0x1000>; > >> + interrupts = <0 171 4>; > > > > This wasn't mentioned. > > > > Is it necessary? > > > > From looking into the code ... > > The driver doesn't use interrupts, so I guess the answer is no. Cut-and-paste error, maybe ? Does the device have any interrupts, even if they're unused? > > > Is it the only interrupt? > > > >> + clocks = <&per_base_clk>; > > > > Similarly, is this the only clock? > > > The driver uses one clock, and it is mandatory. Is this the only clock into the unit? Does it have a name? Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html