From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Chen <peter.chen@freescale.com>
Subject: Re: [Patch v2 13/14] usb: phy-mxs: Add implementation of set_wakeup
Date: Wed, 23 Oct 2013 14:54:45 +0800
Message-ID: <20131023065444.GG8534@shlinux1.ap.freescale.net>
References: <1382421528-17897-1-git-send-email-peter.chen@freescale.com>
 <1382421528-17897-14-git-send-email-peter.chen@freescale.com>
 <20131023063521.GH2839@S2101-09.ap.freescale.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Return-path: <linux-doc-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20131023063521.GH2839@S2101-09.ap.freescale.net>
Sender: linux-doc-owner@vger.kernel.org
To: Shawn Guo <shawn.guo@linaro.org>
Cc: balbi@ti.com, rob.herring@calxeda.com, grant.likely@linaro.org, alexander.shishkin@linux.intel.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, festevam@gmail.com, marex@denx.de, kernel@pengutronix.de, m.grzeschik@pengutronix.de, frank.li@freescale.com, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org
List-Id: devicetree@vger.kernel.org

On Wed, Oct 23, 2013 at 02:35:23PM +0800, Shawn Guo wrote:
> >  
> > +static void mxs_phy_disconnect_line(struct mxs_phy *mxs_phy, bool on)
> > +{
> > +	void __iomem *base = mxs_phy->phy.io_priv;
> > +	bool vbus_is_on = false;
> > +	static bool line_is_disconnected;
> > +	unsigned int vbus_value = 0;
> > +
> > +	/* Only the SoCs have anatop need below operation */
> > +	if (!mxs_phy->disconnect_line_without_vbus_is_needed)
> > +		return;
> 
> As per the comment, shouldn't the if-clause be the following?  Or is the
> comment incorrect?
> 
> 	if (!mxs_phy->regmap_anatop)
> 
> Shawn
> 

Thanks,

I will change the comment to 
	/* If the SoC doesn't need to disconnect line without vbus, quit */

-- 

Best Regards,
Peter Chen