From: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 4/4] imx: add PCI fixup for PEX860X on Gateworks board
Date: Wed, 23 Oct 2013 16:33:54 +0800 [thread overview]
Message-ID: <20131023083352.GP2839@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1382503888-3962-5-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
On Tue, Oct 22, 2013 at 09:51:28PM -0700, Tim Harvey wrote:
<snip>
> @@ -78,6 +80,37 @@ static int ksz9031rn_phy_fixup(struct phy_device *dev)
> return 0;
> }
>
> +/*
> + * fixup for PLX PEX8909 bridge to configure GPIO1-7 as output High
> + * as they are used for slots1-7 PERST#
> + */
> +static void mx6_ventana_pciesw_early_fixup(struct pci_dev *dev)
Please use 'imx' instead of 'mx' where you need an imx prefix. In this
case, it's even fine without the prefix. So I just drop the 'mx6_' from
function name, and applied the patch. Thanks.
Shawn
> +{
> + u32 dw;
> +
> + if (!of_machine_is_compatible("gw,ventana"))
> + return;
> +
> + if (dev->devfn != 0)
> + return;
> +
> + pci_read_config_dword(dev, 0x62c, &dw);
> + dw |= 0xaaa8; // GPIO1-7 outputs
> + pci_write_config_dword(dev, 0x62c, dw);
> +
> + pci_read_config_dword(dev, 0x644, &dw);
> + dw |= 0xfe; // GPIO1-7 output high
> + pci_write_config_dword(dev, 0x644, dw);
> +
> + msleep(100);
> +}
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_PLX, 0x8609,
> + mx6_ventana_pciesw_early_fixup);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_PLX, 0x8606,
> + mx6_ventana_pciesw_early_fixup);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_PLX, 0x8604,
> + mx6_ventana_pciesw_early_fixup);
> +
> static int ar8031_phy_fixup(struct phy_device *dev)
> {
> u16 val;
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-10-23 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 4:51 [PATCH 0/4]: ARM: dts: Add Gateworks Ventana Support Tim Harvey
[not found] ` <1382503888-3962-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
2013-10-23 4:51 ` [PATCH 1/4] ARM: dts: added several new imx-pinmux groups Tim Harvey
[not found] ` <1382503888-3962-2-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
2013-10-23 8:15 ` Shawn Guo
2013-10-23 4:51 ` [PATCH 2/4] ARM: dts: add Gateworks Ventana support Tim Harvey
[not found] ` <1382503888-3962-3-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
2013-10-23 8:23 ` Shawn Guo
2013-10-23 4:51 ` [PATCH 3/4] ARM: dts: disable flexcan by default Tim Harvey
[not found] ` <1382503888-3962-4-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
2013-10-23 7:50 ` Shawn Guo
2013-10-23 4:51 ` [PATCH 4/4] imx: add PCI fixup for PEX860X on Gateworks board Tim Harvey
[not found] ` <1382503888-3962-5-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
2013-10-23 8:33 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023083352.GP2839@S2101-09.ap.freescale.net \
--to=shawn.guo-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).