From: Peter Chen <peter.chen@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: balbi@ti.com, rob.herring@calxeda.com, grant.likely@linaro.org,
alexander.shishkin@linux.intel.com, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, festevam@gmail.com,
marex@denx.de, kernel@pengutronix.de, m.grzeschik@pengutronix.de,
frank.li@freescale.com, gregkh@linuxfoundation.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [Patch v2 02/14] usb: phy-mxs: Add platform judgement code
Date: Wed, 23 Oct 2013 16:55:46 +0800 [thread overview]
Message-ID: <20131023085546.GI8534@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <20131023090443.GR2839@S2101-09.ap.freescale.net>
On Wed, Oct 23, 2013 at 05:04:44PM +0800, Shawn Guo wrote:
> On Wed, Oct 23, 2013 at 02:46:04PM +0800, Peter Chen wrote:
> > How about compare compatible string directly at probe?
> >
> > if (of_device_is_compatible(np, "fsl,imx6q-usbphy"))
> > mxs_phy->devtype = IMX6Q_USB_PHY;
> > else if ((of_device_is_compatible(np, "fsl,imx6sl-usbphy"))
> > mxs_phy->devtype = IMX6SL_USB_PHY;
> > else if (...)
> > ...;
>
> It can work, but in general, we should avoid unnecessary device tree
> lookup. I would suggest something like below.
>
> #define MXS_FLAGS_SUSPEND_ISSUE_1 BIT(0)
> #define MXS_FLAGS_SUSPEND_ISSUE_2 BIT(1)
> #define MXS_FLAGS_LINE_DISCONNECT BIT(2)
>
> struct mxs_phy_data {
> unsigned int flags;
> };
>
> struct mxs_phy {
> ...
> mxs_phy_data *data;
> };
>
> static struct mxs_phy_data imx6sl_usbphy_data = {
> .flags = MXS_FLAGS_LINE_DISCONNECT,
> };
>
> static struct mxs_phy_data imx6q_usbphy_data = {
> .flags = MXS_FLAGS_SUSPEND_ISSUE_2 | MXS_FLAGS_LINE_DISCONNECT,
> };
>
> static struct mxs_phy_data imx23_usbphy_data = {
> .flags = MXS_FLAGS_SUSPEND_ISSUE_1 | MXS_FLAGS_SUSPEND_ISSUE_2,
> };
>
> static const struct of_device_id mxs_phy_dt_ids[] = {
> { .compatible = "fsl,imx6sl-usbphy", .data = &imx6sl_usbphy_data, },
> { .compatible = "fsl,imx6q-usbphy", .data = &imx6q_usbphy_data, },
> { .compatible = "fsl,imx23-usbphy", .data = &imx23_usbphy_data, },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, mxs_phy_dt_ids);
>
> Then you can check the flags for handling different cases. This would
> be more flexible and future proof.
>
Great, I will use that way at chipidea driver too.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2013-10-23 8:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 5:58 [Patch v2 00/14] Add power management support for MXS PHY Peter Chen
2013-10-22 5:58 ` [Patch v2 01/14] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-10-23 2:58 ` Shawn Guo
[not found] ` <1382421528-17897-2-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-10-23 5:56 ` Shawn Guo
2013-10-23 6:17 ` Peter Chen
2013-10-22 5:58 ` [Patch v2 03/14] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-10-22 5:58 ` [Patch v2 04/14] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-10-22 5:58 ` [Patch v2 06/14] usb: phy-mxs: Add anatop regmap Peter Chen
2013-10-22 5:58 ` [Patch v2 07/14] usb: phy: add notify suspend and resume callback Peter Chen
[not found] ` <1382421528-17897-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-10-22 5:58 ` [Patch v2 02/14] usb: phy-mxs: Add platform judgement code Peter Chen
2013-10-23 6:13 ` Shawn Guo
2013-10-23 6:46 ` Peter Chen
2013-10-23 9:04 ` Shawn Guo
2013-10-23 8:55 ` Peter Chen [this message]
2013-10-22 5:58 ` [Patch v2 05/14] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-10-22 5:58 ` [Patch v2 08/14] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-10-22 5:58 ` [Patch v2 11/14] ARM: dts: imx6: Add disconnect-line-without-vbus property for usbphy Peter Chen
2013-10-22 5:58 ` [Patch v2 09/14] usb: phy-mxs: Enable IC fixes for mx6 SoC serial Peter Chen
2013-10-22 5:58 ` [Patch v2 10/14] usb: doc: phy-mxs: update binding for adding disconnect line property Peter Chen
2013-10-23 6:31 ` Shawn Guo
2013-10-23 6:49 ` Peter Chen
2013-10-23 7:08 ` Peter Chen
2013-10-23 8:44 ` Shawn Guo
2013-10-22 5:58 ` [Patch v2 12/14] usb: phy: Add set_wakeup API Peter Chen
2013-10-22 5:58 ` [Patch v2 13/14] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-10-23 6:35 ` Shawn Guo
2013-10-23 6:54 ` Peter Chen
2013-10-22 5:58 ` [Patch v2 14/14] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-10-22 9:29 ` [Patch v2 00/14] Add power management support for MXS PHY Peter Chen
2013-10-28 8:20 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023085546.GI8534@shlinux1.ap.freescale.net \
--to=peter.chen@freescale.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@freescale.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=marex@denx.de \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).