From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: "Gupta, Pekon" <pekon@ti.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"Pawel.Moll@arm.com" <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"tony@atomide.com" <tony@atomide.com>,
"jp.francois@cynove.com" <jp.francois@cynove.com>,
"dedekind1@gmail.com" <dedekind1@gmail.com>,
"avinashphilipk@gmail.com" <avinashphilipk@gmail.com>,
"Balbi, Felipe" <balbi@ti.com>,
"robherring2@gmail.com" <robherring2@gmail.com>,
"bcousson@baylibre.com" <bcousson@baylibre.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"olof@lixom.net" <olof@lixom.net>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"ivan.djelic@parrot.com" <ivan.djelic@parrot.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
dwmw2@infradead.org
Subject: Re: [PATCH v10 04/10] mtd: nand: omap: fix device scan: NAND_CMD_READID, NAND_CMD_RESET, CMD_CMD_PARAM use only x8 bus
Date: Wed, 23 Oct 2013 09:55:17 -0300 [thread overview]
Message-ID: <20131023125516.GA2458@localhost> (raw)
In-Reply-To: <5267690C.9080005@gmail.com>
Brian,
On Tue, Oct 22, 2013 at 11:13:32PM -0700, Brian Norris wrote:
> On 10/22/2013 10:07 PM, Gupta, Pekon wrote:
> >> From: Brian Norris [mailto:computersforpeace@gmail.com]
> >> On Sat, Oct 19, 2013 at 02:14:08PM +0530, Pekon Gupta wrote:
> > [...]
> >
> >>>
> >>> Thus this patch run nand_scan_ident() with driver configured as x8 device.
> >>
> >> So are you saying that the driver currently doesn't work if you started
> >> in x16 buswidth? Are you having problems with a particular setup? What
> >> sort of devices are you testing?
> >>
> > No, I'm saying that you cannot read ONFI params in x16 mode.
> > And, that is what was pointed out in following commit log also ..
> > (Reference to 3.3.2. Target Initialization: given above)
> > So, if I run nand_scan_ident() in x16 mode, my ONFI detection would
> > fail for sure ..
>
> But you cannot just run nand_scan_ident() with !(chip->options &
> NAND_BUSWIDTH_16) when your devices is x16. You need to solve the ONFI
> detection problem while correctly specifying NAND_BUSWIDTH_16.
>
> Since you didn't answer the other 2 questions there: are you testing any
> x16 devices?
>
I'm jumping on this thread without having read all the discussion, sorry
about that.
FWIW, I have a Beaglebone with a 16-bit bus NAND attached to it.
Coincidentally, yesterday I was doing some tests as I'm ramping up the
NAND and I found that weird double nand_scan_ident() call.
The whole thing looks buggy to me, so I'm happy to help, review, test
and patches to take care of this.
I'm using some TI SDK with some ancient v3.2.x (with no git history!),
but from this discussion it seems the issue is still present in
mainline.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-23 12:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 8:44 [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes Pekon Gupta
2013-10-19 8:44 ` [PATCH v10 01/10] ARM: OMAP2+: cleaned-up DT support of various " Pekon Gupta
[not found] ` <1382172254-12448-1-git-send-email-pekon-l0cyMroinI0@public.gmane.org>
2013-10-19 8:44 ` [PATCH v10 02/10] mtd: nand: omap: combine different flavours of 1-bit hamming ecc schemes Pekon Gupta
2013-10-19 8:44 ` [PATCH v10 03/10] mtd: nand: omap: cleanup: replace local references with generic framework names Pekon Gupta
2013-10-19 8:44 ` [PATCH v10 04/10] mtd: nand: omap: fix device scan: NAND_CMD_READID, NAND_CMD_RESET, CMD_CMD_PARAM use only x8 bus Pekon Gupta
2013-10-22 20:16 ` Brian Norris
2013-10-23 5:07 ` Gupta, Pekon
2013-10-23 6:13 ` Brian Norris
2013-10-23 12:30 ` Gupta, Pekon
2013-10-23 12:55 ` Ezequiel Garcia [this message]
2013-10-23 13:15 ` Gupta, Pekon
[not found] ` <20980858CB6D3A4BAE95CA194937D5E73EA2A0CB-yXqyApvAXouIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-10-23 13:24 ` Ezequiel Garcia
2013-10-23 14:46 ` Ezequiel Garcia
2013-10-24 12:59 ` Gupta, Pekon
2013-10-24 13:07 ` Ezequiel Garcia
2013-10-19 8:44 ` [PATCH v10 05/10] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe Pekon Gupta
2013-10-19 8:44 ` [PATCH v10 06/10] mtd: nand: omap: clean-up ecc layout for BCH ecc schemes Pekon Gupta
2013-10-19 8:44 ` [PATCH v10 07/10] mtd: nand: omap: use drivers/mtd/nand/nand_bch.c wrapper for BCH ECC instead of lib/bch.c Pekon Gupta
2013-10-19 8:44 ` [PATCH v10 08/10] ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt Pekon Gupta
2013-10-19 8:44 ` [PATCH v10 09/10] mtd: nand: omap: updated devm_xx for all resource allocation and free calls Pekon Gupta
2013-10-19 8:44 ` [PATCH v10 10/10] mtd: nand: omap: remove selection of BCH ecc-scheme via KConfig Pekon Gupta
2013-10-23 13:44 ` Ezequiel Garcia
2013-10-23 13:55 ` Gupta, Pekon
2013-10-23 14:13 ` Ezequiel Garcia
2013-10-24 19:49 ` Javier Martinez Canillas
2013-10-24 20:05 ` Ezequiel Garcia
2013-10-22 20:30 ` [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes Brian Norris
2013-10-23 5:10 ` Gupta, Pekon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023125516.GA2458@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=Pawel.Moll@arm.com \
--cc=arnd@arndb.de \
--cc=avinashphilipk@gmail.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.djelic@parrot.com \
--cc=jp.francois@cynove.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pekon@ti.com \
--cc=robherring2@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).