Re: [PATCHv6][ 3/7] ARM: imx{25,27} DT: Permit the selection of the imxfb framebuffer driver.

["Eric Bénard" <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>]

Hi Shawn,

Le Thu, 24 Oct 2013 16:31:45 +0800,
Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> a écrit :

> On Thu, Oct 24, 2013 at 10:20:11AM +0200, Eric Bénard wrote:
> > Hi Shawn,
> > 
> > Le Thu, 24 Oct 2013 16:15:34 +0800,
> > Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> a écrit :
> > > >  config FB_IMX
> > > >  	tristate "Freescale i.MX1/21/25/27 LCD support"
> > > > -	depends on FB && IMX_HAVE_PLATFORM_IMX_FB
> > > > +	depends on FB && HAVE_IMX_FB
> > > 
> > > Or simply have it depend on ARCH_MXC?
> > > 
> > > 	depends on FB && ARCH_MXC
> > > 
> > but not all MXC have IMX_FB : isn't that a problem ?
> 
> Is it really a problem that you see this option when you configure an
> imx51 kernel?  The prompt clearly tells you do not need this option for
> an imx51 kernel.  Or will it cause any real problem even if you select
> it for an imx51 kernel, except you build in a driver which will never be
> instantiated?  I've seen drivers even start drop ARCH_* dependency to
> get a better randconfig build test coverage.
> 
not really a problem for me. If the policy is not to narrow the choices
to only the SOC which have the peripheral then we follow it and take
your ARCH_MXC approach which is far simpler.

Thanks,
Eric

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html