From: NeilBrown <neilb@suse.de>
To: Grant Likely <grant.likely@linaro.org>
Cc: Kumar Gala <galak@codeaurora.org>,
Anton Vorontsov <anton@enomsg.org>,
David Woodhouse <dwmw2@infradead.org>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Belisko Marek <marek.belisko@gmail.com>,
"Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH] twl4030_charger: add devicetree support.
Date: Thu, 24 Oct 2013 21:41:10 +1100 [thread overview]
Message-ID: <20131024214110.2845670d@notabene.brown> (raw)
In-Reply-To: <20131024100652.6B31DC4039D@trevor.secretlab.ca>
[-- Attachment #1: Type: text/plain, Size: 1925 bytes --]
On Thu, 24 Oct 2013 11:06:52 +0100 Grant Likely <grant.likely@linaro.org>
wrote:
> On Thu, 24 Oct 2013 04:44:03 -0500, Kumar Gala <galak@codeaurora.org> wrote:
> >
> > On Oct 24, 2013, at 12:50 AM, NeilBrown wrote:
> >
> > >
> > > [my first device-tree related patch. Please let me know what I got wrong so
> > > I wont repeat the mistake in all the others I have queued]
> > >
> > > This allows the charger to be enabled with devicetree, and
> > > allows the parameters for charging the backup battery to be set.
> > >
> > > Signed-off-by: NeilBrown <neilb@suse.de>
> > >
> > > diff --git a/Documentation/devicetree/bindings/power/twl-charger.txt b/Documentation/devicetree/bindings/power/twl-charger.txt
> > > new file mode 100644
> > > index 0000000..8afaa9a
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/power/twl-charger.txt
> > > @@ -0,0 +1,20 @@
> > > +TWL BCI (Battery Charger Interface)
> > > +
> > > +Required properties:
> > > +- compatible:
> > > + - "ti,twl4030-bci"
> > > +- interrupts: two interrupt lines from the TWL SIH (secondary
> > > + interrupt handler) - interrupts 9 and 2.
> > > +
> > > +Optional properties:
> > > +- bb-uvolt: microvolts for charging the backup battery.
> > > +- bb-uamp: microamps for charging the backup battery.
> >
> > prop should have vendor prefix.
> >
> > ti,bb-uvolt, ti,bb-uamp
>
> Agreed. Otherwise:
OK, I'll do that - thanks.
NeilBrown
>
> Acked-by: Grant Likely <grant.likely@linaro.org>
>
> >
> > - k
> >
> > > +
> > > +Examples:
> > > +
> > > +bci {
> > > + compatible = "ti,twl4030-bci";
> > > + interrupts = <9>, <2>;
> > > + bb-uvolt = <3200000>;
> > > + bb-uamp = <150>;
> > > +};
> >
> > --
> > Employee of Qualcomm Innovation Center, Inc.
> > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2013-10-24 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 5:50 [PATCH] twl4030_charger: add devicetree support NeilBrown
2013-10-24 9:44 ` Kumar Gala
2013-10-24 10:06 ` Grant Likely
2013-10-24 10:41 ` NeilBrown [this message]
2013-10-25 3:56 ` Kumar Gala
-- strict thread matches above, loose matches on Subject: below --
2013-10-31 6:05 NeilBrown
2013-11-13 6:40 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024214110.2845670d@notabene.brown \
--to=neilb@suse.de \
--cc=anton@enomsg.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=hns@goldelico.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).