From: Lee Jones <lee.jones@linaro.org>
To: Grant Likely <grant.likely@linaro.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
sameo@linux.intel.com, broonie@kernel.org,
linus.walleij@linaro.org, akpm@linux-foundation.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
rtc-linux@googlegroups.com, rob.herring@calxeda.com,
mark.rutland@arm.com, pawel.moll@arm.com, swarren@wwwdotorg.org,
rob@landley.net, ijc+devicetree@hellion.org.uk,
Florian Lobmaier <florian.lobmaier@ams.com>
Subject: Re: [PATCH V5 REPOST] mfd: add support for ams AS3722 PMIC
Date: Sat, 26 Oct 2013 09:19:02 -0700 [thread overview]
Message-ID: <20131026161902.GA7698@lee--X1> (raw)
In-Reply-To: <20131025200754.D222AC4058E@trevor.secretlab.ca>
Hi Grant,
> > Acked-by: Stephen Warren <swarren@nvidia.com>
> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> > Signed-off-by: Florian Lobmaier <florian.lobmaier@ams.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
<snip>
> > + Optional properties:
> > + -------------------
> > + The input supply of regulators are the optional properties on the
> > + regulator node. The input supply of these regulators are provided
> > + through following properties:
> > + vsup-sd2-supply: Input supply for SD2.
> > + vsup-sd3-supply: Input supply for SD3.
> > + vsup-sd4-supply: Input supply for SD4.
> > + vsup-sd5-supply: Input supply for SD5.
> > + vin-ldo0-supply: Input supply for LDO0.
> > + vin-ldo1-6-supply: Input supply for LDO1 and LDO6.
> > + vin-ldo2-5-7-supply: Input supply for LDO2, LDO5 and LDO7.
> > + vin-ldo3-4-supply: Input supply for LDO3 and LDO4.
> > + vin-ldo9-10-supply: Input supply for LDO9 and LDO10.
> > + vin-ldo11-supply: Input supply for LDO11.
>
> What is the data in these properties? The documentation isn't clear.
>
> In principle, the binding looks okay to me.
The properties to which you refer are standard regulator supply
bindings specified here [1]. Specifically:
"<name>-supply: phandle to the parent supply/regulator node"
The DT portion has already been Acked by Stephen and applied by me.
[1] Documentation/devicetree/bindings/regulator/regulator.txt
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-10-26 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 7:38 [PATCH V5 REPOST] mfd: add support for ams AS3722 PMIC Laxman Dewangan
2013-10-22 8:40 ` Lee Jones
2013-10-25 20:07 ` Grant Likely
2013-10-26 16:19 ` Lee Jones [this message]
2013-10-27 13:49 ` Grant Likely
2014-06-06 15:28 ` Lee Jones
2014-06-09 7:10 ` Laxman Dewangan
2014-06-09 11:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131026161902.GA7698@lee--X1 \
--to=lee.jones@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.lobmaier@ams.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).