From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V5 REPOST] mfd: add support for ams AS3722 PMIC Date: Sat, 26 Oct 2013 09:19:02 -0700 Message-ID: <20131026161902.GA7698@lee--X1> References: <1382427526-2390-1-git-send-email-ldewangan@nvidia.com> <20131025200754.D222AC4058E@trevor.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20131025200754.D222AC4058E@trevor.secretlab.ca> Sender: linux-doc-owner@vger.kernel.org To: Grant Likely Cc: Laxman Dewangan , sameo@linux.intel.com, broonie@kernel.org, linus.walleij@linaro.org, akpm@linux-foundation.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, rob.herring@calxeda.com, mark.rutland@arm.com, pawel.moll@arm.com, swarren@wwwdotorg.org, rob@landley.net, ijc+devicetree@hellion.org.uk, Florian Lobmaier List-Id: devicetree@vger.kernel.org Hi Grant, > > Acked-by: Stephen Warren > > Signed-off-by: Laxman Dewangan > > Signed-off-by: Florian Lobmaier > > Signed-off-by: Lee Jones > > + Optional properties: > > + ------------------- > > + The input supply of regulators are the optional properties on the > > + regulator node. The input supply of these regulators are provided > > + through following properties: > > + vsup-sd2-supply: Input supply for SD2. > > + vsup-sd3-supply: Input supply for SD3. > > + vsup-sd4-supply: Input supply for SD4. > > + vsup-sd5-supply: Input supply for SD5. > > + vin-ldo0-supply: Input supply for LDO0. > > + vin-ldo1-6-supply: Input supply for LDO1 and LDO6. > > + vin-ldo2-5-7-supply: Input supply for LDO2, LDO5 and LDO7. > > + vin-ldo3-4-supply: Input supply for LDO3 and LDO4. > > + vin-ldo9-10-supply: Input supply for LDO9 and LDO10. > > + vin-ldo11-supply: Input supply for LDO11. >=20 > What is the data in these properties? The documentation isn't clear. >=20 > In principle, the binding looks okay to me. The properties to which you refer are standard regulator supply bindings specified here [1]. Specifically: "-supply: phandle to the parent supply/regulator node" The DT portion has already been Acked by Stephen and applied by me. [1] Documentation/devicetree/bindings/regulator/regulator.txt --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog