Re: [PATCH v10 11/12] V4L: Add DT binding doc for s5k4e5 image sensor

[Mark Rutland <mark.rutland@arm.com>]

On Fri, Oct 18, 2013 at 06:37:38AM +0100, Arun Kumar K wrote:
> S5K4E5 is a Samsung raw image sensor controlled via I2C.
> This patch adds the DT binding documentation for the same.
> 
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  .../devicetree/bindings/media/samsung-s5k4e5.txt   |   45 ++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/samsung-s5k4e5.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/samsung-s5k4e5.txt b/Documentation/devicetree/bindings/media/samsung-s5k4e5.txt
> new file mode 100644
> index 0000000..0fca087
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/samsung-s5k4e5.txt
> @@ -0,0 +1,45 @@
> +* Samsung S5K4E5 Raw Image Sensor
> +
> +S5K4E5 is a raw image sensor with maximum resolution of 2560x1920
> +pixels. Data transfer is carried out via MIPI CSI-2 port and controls
> +via I2C bus.
> +
> +Required Properties:
> +- compatible	: must be "samsung,s5k4e5"

s/must be/should contain/

> +- reg		: I2C device address
> +- reset-gpios	: specifier of a GPIO connected to the RESET pin
> +- clocks	: should contain the sensor's EXTCLK clock specifier, from
> +		  the common clock bindings

I would reword this to reference clock-names so as to make the ordering
relationship explicit.

With that, as everything else looks sane:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks
Mark.