From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hiroshi Doyu Subject: Re: [PATCHv3 01/19] [HACK] of: dev_node has struct device pointer Date: Fri, 1 Nov 2013 11:09:49 +0100 Message-ID: <20131101.120949.1917997867370964780.hdoyu@nvidia.com> References: <20131031.101405.2229107340254709582.hdoyu@nvidia.com><52728754.60307@wwwdotorg.org><20131101095349.GI27864@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131101095349.GI27864-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Stephen Warren , "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" List-Id: devicetree@vger.kernel.org Thierry Reding wrote @ Fri, 1 Nov 2013 10:53:50 +0100: > * PGP Signed by an unknown key > > On Thu, Oct 31, 2013 at 10:37:40AM -0600, Stephen Warren wrote: > > On 10/31/2013 02:14 AM, Hiroshi Doyu wrote: > > > Thierry Reding wrote @ Wed, 30 Oct 2013 23:41:09 +0100: > > > > > >> My earlier proposal for deferred interrupt reference resolution actually > > >> tries to solve that problem within the core. Essentially what it does is > > >> add a new function that gets called right before the driver's .probe() > > >> function, so that it can parse standard resources and services from DT, > > >> such as the interrupts property. This could theoretically be done for > > >> other resources such as reg as well, but it really only matters where > > >> the resource can be dynamic (as is the case for interrupts). > > >> > > >> In this case I would envision a standard OF function to associate a > > >> device with its IOMMU. Perhaps something like: > > >> > > >> int of_iommu_attach(struct device *dev); > > >> > > >> That could be called by the core independent of the specific device and > > >> IOMMU. IOMMU-specifics can probably be handled using .of_xlate(), quite > > >> in a similar way to GPIO or regulators. > > >> > > >> That way drivers can remain agnostic of the IOMMU while still being able > > >> to take advantage of deferred probing. > > > > > > This could be simpler than making "bus_notifier" return "-EPROBE_DEFER". > > > > > > The disadvantage of this is that we may need to provide the similar > > > of_<"subsystem">_attach() per subsytem if needed. > > > > Well, "per subsystem" here means per subsystem that is providing > > resources, not per subsystem that is consuming resources. How many > > subsystems are you expecting to provide resources like this? At present, > > I believe IOMMU is the only subsystem missing some kind of API for > > clients to acquire the relevant resource. I don't think there's any > > scalability problem here. > > Furthermore if the subsystem wants to provide resources then it needs > such a function anyway, so there really isn't any overhead here. Ok, the scalability won't be an issue since the number of subsystems to provide resources/services is usually limited, anyway.